feat: run tasks in dedicated terminals#256
Open
ubershmekel wants to merge 1 commit into
Open
Conversation
Route both provider-generated tasks (toTask) and tasks resolved from tasks.json (resolveTask) through a shared useDedicatedTerminal helper so each task gets its own panel, while letting user-defined presentation options in tasks.json take precedence. Also fixes resolveTask, which previously hardcoded `task <name>` and ran with no cwd: it now honors the configured task binary path, sets the workspace as cwd, and forwards CLI args. Command-string construction is shared via buildTaskCommand to keep the two paths in sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was tired of VS code not launching my test task in a separate terminal while a debug task was running. So I made this PR and fork.
Another problem was that when a task is running VS Code would pop up a "select instance to terminate" dialog. Then it would run the wrong task somehow.
The change itself was done by Codex, then Claude reviewed the changes and provided the following CL description...
Route both provider-generated tasks (toTask) and tasks resolved from tasks.json (resolveTask) through a shared useDedicatedTerminal helper so each task gets its own panel, while letting user-defined presentation options in tasks.json take precedence.
Also fixes resolveTask, which previously hardcoded
task <name>and ran with no cwd: it now honors the configured task binary path, sets the workspace as cwd, and forwards CLI args. Command-string construction is shared via buildTaskCommand to keep the two paths in sync.