Add favicon assets#464
Merged
Merged
Conversation
chalin
changed the title
- Contributes to google/docsy#2357 - Adds `favicon.svg`, `favicon.ico`, and `apple-touch-icon.png` under `static/` so the Docsy theme's default favicons partial discovers and links them; the example lost its favicon when google/docsy#2653 dropped the theme's bundled defaults - Reuses docsy.dev's favicon assets verbatim -- all three files are byte-identical to docsy.dev's so the example provably uses the same Docsy-logo artwork it already shows in its navbar - Bumps the Docsy theme module to a commit that includes the discovery partial (google/docsy#2654) - Adds `tests/favicons.test.mjs` asserting the three discovered `<link>`s render in the built home page
chalin
force-pushed
the
chalin-favicons-2026-0614
branch
from
9b2f9b0 to
85f8730
Compare
Collaborator
Author
|
Validated on the deploy preview: https://deploy-preview-464--goldydocs.netlify.app/
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
favicon.svg,favicon.ico, andapple-touch-icon.pngunderstatic/so the Docsy theme's default favicons partial discovers and links them; the example lost its favicon when Remove default theme favicons and modernize docsy.dev's icons docsy#2653 dropped the theme's bundled defaultstests/favicons.test.mjsasserting the three discovered<link>s render in the built home page