docs: clarify GPU CDI hooks and nvidia-container-runtime modes#13383
Open
a7i wants to merge 1 commit into
Open
docs: clarify GPU CDI hooks and nvidia-container-runtime modes#13383a7i wants to merge 1 commit into
a7i wants to merge 1 commit into
Conversation
a7i
marked this pull request as draft
June 7, 2026 23:28
Document nvidia-cdi-hook vs nvidia-ctk hook CDI forms, static vs device-plugin CDI spec sources, and host CDI enablement without nvidia-ctk cdi generate. Document disable-device-node-modification skip under nvproxy, NVIDIA_CDI_HOOK_PATH, CDI_FEATURE_FLAGS for gVisor (disable-ipc-discoverer), and scope the legacy-vs-csv mode note to the nvidia-container-runtime shim only.
| When running GPU containers under gVisor, also set | ||
| `CDI_FEATURE_FLAGS=disable-ipc-discoverer` on the device plugin. This omits the | ||
| `nvidia-persistenced` Unix socket bind mount from the CDI spec; gVisor's gofer | ||
| cannot bind-mount that socket and container creation fails if it is present. |
Contributor
There was a problem hiding this comment.
Is it true that it fails if it's present? I don't think that's accurate (at least when I tested it). I introduced this flag mainly because I realized it shouldn't be passed through in most cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nvidia-cdi-hookand legacynvidia-ctk hookCDI hook forms.disable-device-node-modificationis a no-op under nvproxy and is skipped when the hook path isnvidia-cdi-hook; recommendNVIDIA_CDI_HOOK_PATH=/usr/bin/nvidia-cdi-hookfor k8s-device-plugin defaults that emit thenvidia-ctkform.nvidia-container-runtimeshim only; CDI bypasses the shim and is unaffected.Test plan