chore(generator): use {% set %} to extract repeated logic in conditionals#17890
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors several Jinja2 templates to pre-calculate whether a service has auto-populated fields, replacing complex inline filters with a simpler boolean variable. The review feedback correctly points out that defining variables and executing loops before the {% extends %} tag violates Jinja2 standards, which can lead to syntax errors or scoping issues. It is recommended to move these variable definitions and loops inside the {% block content %} block to ensure correct rendering and compliance.
hebaalazzeh
force-pushed
the
global-variable-autopop-fields
branch
5 times, most recently
from
July 24, 2026 17:14
5ebf4bf to
2360399
Compare
hebaalazzeh
marked this pull request as ready for review
July 24, 2026 17:15
hebaalazzeh
force-pushed
the
global-variable-autopop-fields
branch
from
July 24, 2026 17:37
2360399 to
69cc49e
Compare
ohmayr
changed the title
ohmayr
changed the title
{% set %} to extract repeated logic in conditionals
ohmayr
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the use of global variable for auto populated fields, we are making sure that the Jinja variables are defined at the top of the file so they can easily reference throughout the template.