feat(storage): Making crc32c default for download#34002
Merged
v-pratap merged 4 commits intoJun 12, 2026
Merged
Conversation
shubhangi-google
changed the title
v-pratap
reviewed
Jun 3, 2026
| @@ -1098,7 +1098,7 @@ def update generation: nil, | |||
| # downloaded.rewind | |||
| # downloaded.read #=> "world" | |||
| # | |||
| def download path = nil, verify: :md5, encryption_key: nil, range: nil, | |||
| def download path = nil, verify: :crc32c, encryption_key: nil, range: nil, | |||
There was a problem hiding this comment.
Please ensure the official documentation for checksumming is updated to reflect that :crc32c is now the default instead of :md5
| @@ -320,7 +320,7 @@ def file.md5 | |||
| end | |||
|
|
|||
| describe "verified downloads" do | |||
| it "verifies m5d by default" do | |||
| it "verifies crc32c by default" do | |||
There was a problem hiding this comment.
How it was working before, it was using m5d instead of md5? Does this test validate the actual use case?
Contributor
Author
There was a problem hiding this comment.
this part is just description of test case which would have been typed incorrectly
| def file.md5 | ||
| "1B2M2Y8AsgTpgAmY7PhCfg==" | ||
| # Stub the crc32c to match. | ||
| def file.crc32c |
There was a problem hiding this comment.
Can you also add non empty file verification?
v-pratap
approved these changes
Jun 5, 2026
kalragauri
changed the title
kalragauri
added
do not merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the default verification method for file downloads from MD5 to CRC32C across the google-cloud-storage library and updates the corresponding tests.