docs: Quickstart pages mention iOS-only for condensed headers#4551
Open
Austin-Spriggs wants to merge 2 commits into
Open
docs: Quickstart pages mention iOS-only for condensed headers#4551Austin-Spriggs wants to merge 2 commits into
Austin-Spriggs wants to merge 2 commits into
Conversation
…art pages now mentions iOS-only
|
@Austin-Spriggs is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
brandyscarney
left a comment
brandyscarney
left a comment
Member
There was a problem hiding this comment.
Sorry I wasn't clear about what versions to update! We don't deploy v5 anymore so we don't need to update that one but the rest looks good! 🙂
| ``` | ||
|
|
||
| This creates a page with a header and scrollable content area. The second header shows a [collapsible large title](/docs/api/title.md#collapsible-large-titles) that displays when at the top of the content, then condenses to show the smaller title in the first header when scrolling down. | ||
| This creates a page with a header and scrollable content area. TThe second header shows a [collapsible large title](/docs/api/title.md#collapsible-large-titles) that displays on iOS devices when at the top of the content, then condenses to show the smaller title in the first header when scrolling down. |
Member
There was a problem hiding this comment.
Suggested change
| This creates a page with a header and scrollable content area. TThe second header shows a [collapsible large title](/docs/api/title.md#collapsible-large-titles) that displays on iOS devices when at the top of the content, then condenses to show the smaller title in the first header when scrolling down. | |
| This creates a page with a header and scrollable content area. The second header shows a [collapsible large title](/docs/api/title.md#collapsible-large-titles) that displays on iOS devices when at the top of the content, then condenses to show the smaller title in the first header when scrolling down. |
Member
There was a problem hiding this comment.
Can you revert this change? We don't need to update the v5 quickstart since it won't be redeployed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I added a line to the description of the View the Home Page section that mentions that the condensed headers only appear on iOS devices.
Change Type
Rationale / Problems Fixed
Fixes a problem that occurred to me while following the Vue Quickstart guide. The guide briefly mentioned the collapsible title and how it works, but didn't mention that it was iOS-only. I did find that information further in the docs, but as a simple fix, I figured it would be nice to have it here for a smoother on-boarding process.