chore: Migrate dotnet-sdk-internal into dotnet-core#298
Open
jsonbailey wants to merge 3 commits into
Open
Conversation
jsonbailey
force-pushed
the
jb/sdk-2572/migrate-internal-to-dotnet-core
branch
from
f2a2676 to
8475a80
Compare
Relocate the LaunchDarkly.InternalSdk package from the standalone dotnet-sdk-internal repo into pkgs/shared/internal, following the pattern used for dotnet-sdk-common (#105) and its follow-up corrections (#117/#121/#123/#124). - Copy src/ and test/ verbatim. Preserve the existing strong-name signing key: the same S3 source (launchdarkly-releaser/dotnet/LaunchDarkly.snk) is used, so the assembly public-key token is unchanged. - Add monorepo release wiring: github_actions.env, docfx.json, CI workflow (server-shared-internal.yml), release-please config + manifest (seeded at the current version 3.8.0), and release.yml / release-please.yml entries. - No consumer changes; the server/client SDKs keep their published LaunchDarkly.InternalSdk PackageReference (bumping that is a follow-up). SDK-2572
jsonbailey
force-pushed
the
jb/sdk-2572/migrate-internal-to-dotnet-core
branch
from
b4970bb to
ef4e59b
Compare
kinyoklion
reviewed
Jul 7, 2026
| ], | ||
| "globalMetadata": { | ||
| "_appName": "LaunchDarkly.InternalSdk", | ||
| "_appTitle": "LaunchDarkly internal common code for .NET and Xamarin clients", |
Member
There was a problem hiding this comment.
We could probably remove Xamarin here.
kinyoklion
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Migrates the
LaunchDarkly.InternalSdkpackage from the standalonedotnet-sdk-internalrepo into this monorepo atpkgs/shared/internal/, following the pattern used fordotnet-sdk-common(#105) and its follow-up corrections (#117, #121, #123, #124).Resolves SDK-2572.
What's included
pkgs/shared/internal/—src/andtest/copied verbatim from the source repo (net8 work from dotnet-sdk-internal chore(main): release LaunchDarkly.ServerSdk.Ai 0.6.0 #69, released as 3.8.0), plusREADME/CONTRIBUTING/CHANGELOG/PROVENANCE/.slnand the package's own public keyLaunchDarkly.InternalSdk.pk.github_actions.envsources the same S3 key the package uses today (launchdarkly-releaser/dotnet/LaunchDarkly.snk), so the assembly's strong-name public-key token is unchanged. The only csproj change is repointingAssemblyOriginatorKeyFileto the new repo-relative path.github_actions.env,docfx.json, CI workflow (server-shared-internal.yml), release-please config + manifest entries, andrelease.yml/release-please.ymljobs. Built on common's post-fix baseline, so it already incorporates the naming (chore: Fix naming of common packages for release please #117),release-type: simple(chore: Set release-please project type #121), unquoted key-pair (chore: Update assembly key path pair #123), and docfx (chore: Add missing docfx configuration files #124) corrections.Not included (deliberately)
LaunchDarkly.InternalSdkPackageReference; bumping them to a monorepo-published version is a separate follow-up PR.Validation
net8.0: 180/180 unit tests pass in the new location.netstandard2.0: builds clean. (net462is Windows-only — covered by the CI matrix.)release-please-config.json/ manifest are valid JSON;package-namematches the real<PackageId>and theextra-filescsproj path resolves correctly.Note
Low Risk
Additive monorepo migration and workflow config; no runtime or consumer dependency changes in this PR.
Overview
Moves
LaunchDarkly.InternalSdkfrom the standalonedotnet-sdk-internalrepo intopkgs/shared/internal/, mirroring how other shared packages live in this monorepo.The package source, tests, docs, and changelog land under that path and are wired into
DotnetCore.sln. Release-please is seeded at 3.8.0 in.release-please-manifest.json, with a newrelease-shared-internaljob andpkgs/shared/internalon the shared release workflow. A dedicatedserver-shared-internal.ymlCI workflow builds/tests on Ubuntu (netstandard2.0/net8.0) and Windows (net462).Signing stays on the existing S3 strong-name key via
github_actions.env; the csproj only updates the key file path for this repo layout. No server/client SDKPackageReferenceupdates in this PR.Reviewed by Cursor Bugbot for commit bfa34b0. Bugbot is set up for automated code reviews on this repo. Configure here.