Skip to content

feat: Add FDv2 data system support to NodeClient#1775

Open
joker23 wants to merge 5 commits into
mainfrom
skz/sdk-2195/node-client-sdk-next-fdv2-support
Open

feat: Add FDv2 data system support to NodeClient#1775
joker23 wants to merge 5 commits into
mainfrom
skz/sdk-2195/node-client-sdk-next-fdv2-support

Conversation

@joker23

@joker23 joker23 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

SDK-2468


Note

Medium Risk
Touches flag data ingestion and connection/offline transitions for FDv2-enabled clients; FDv1 is isolated but incorrect mode or flush handling could affect live updates and events.

Overview
NodeClient can use the shared FDv2 data stack when dataSystem is configured, while the existing FDv1 NodeDataManager path stays unchanged.

Construction wires createFDv2DataManagerBase with desktop defaults, transition table, and a buildQueryParams hook (auth / h for client-side ID; empty params and hash warnings for mobile key). Connection mode is tracked on the client (getConnectionMode / isOffline); FDv2 setConnectionMode validates modes, no-ops after close or on duplicate mode, serializes concurrent transitions (flush before offline, then event sending toggles), and still delegates to the FDv2 data manager.

CI runs FDv1 contract tests without stopping the harness service, then adds a FDv2 harness run (v3) with testharness-suppressions-fdv2.txt. The contract test service advertises client-event-source-http-errors and documents deferred fdv1-fallback support. Unit coverage lives in NodeClientFDv2.test.ts.

Reviewed by Cursor Bugbot for commit 254d1a2. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 38747 bytes
Compressed size limit: 39000
Uncompressed size: 212249 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 26365 bytes
Compressed size limit: 29000
Uncompressed size: 129044 bytes

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 32027 bytes
Compressed size limit: 34000
Uncompressed size: 114248 bytes

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179504 bytes
Compressed size limit: 200000
Uncompressed size: 831427 bytes

@joker23

joker23 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

cursor[bot]

This comment was marked as resolved.

@joker23

joker23 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 14bd7e4. Configure here.

@joker23 joker23 force-pushed the skz/sdk-2195/node-client-sdk-next-fdv2-support branch 2 times, most recently from 65b044a to c4aa363 Compare June 26, 2026 17:51
@joker23 joker23 marked this pull request as ready for review June 26, 2026 17:57
@joker23 joker23 requested a review from a team as a code owner June 26, 2026 17:57
devin-ai-integration[bot]

This comment was marked as resolved.

@joker23 joker23 marked this pull request as draft June 29, 2026 18:10
@joker23 joker23 force-pushed the skz/sdk-2195/node-client-sdk-next-fdv2-support branch from f4a4c39 to bc6706f Compare June 29, 2026 18:48
@joker23 joker23 marked this pull request as ready for review June 29, 2026 22:42
joker23 added 5 commits July 7, 2026 14:07
fix: Restore FDv2 connection mode when an offline transition fails

fix: Await in-flight FDv2 transition on duplicate-mode setConnectionMode
@joker23 joker23 force-pushed the skz/sdk-2195/node-client-sdk-next-fdv2-support branch from bc6706f to 254d1a2 Compare July 7, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant