chore: reverts judge stripping behavior#1777
Conversation
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk-common size report |
|
@launchdarkly/browser size report |
|
@launchdarkly/js-client-sdk size report |
|
Should the agent runners also be updated (eg ) now that the base runner interface can take instring | LDMessage[]?
|
I don't believe so. Agent runners should only be taking in a single instructions block, not an array of messages. Waiting on @jsonbailey for reviews on these though since it's reverting behavior |
Requirements
Related issues
https://launchdarkly.atlassian.net/jira/software/c/projects/AIC/boards/2045?selectedIssue=AIC-2848
Describe the solution you've provided
This is a reversion of functionality that was added.
Describe alternatives you've considered
Reverts behavior from #1364 that stripped messages off of the judges and then re-created them.
Additional context
This was discussed and there are various concerns about this behavior. Since this is a semi-permanent solution once changes are applied on the server side we don't want to take this step yet.
Note
Medium Risk
Judge configs again expose full legacy message lists to callers, which can change runtime prompts versus the stripped behavior. The widened
Runner.runsignature is a public API change, though string-based call paths stay backward compatible.Overview
Reverts judge message stripping from a prior change:
stripLegacyJudgeMessages, reserved-variable re-injection formessage_history/response_to_evaluate, and related warnings are removed.judgeConfignow returns flag-evaluated messages unchanged (including legacy{{message_history}}/{{response_to_evaluate}}template rows).Extends the
Runnerprotocol sorunacceptsstring | LDMessage[]. String inputs keep the existing behavior (config messages prepended, multi-turn history updated). A pre-builtLDMessage[]is sent to the provider as-is—no config merge and no history mutation—implemented in the OpenAI, LangChain, and Vercel model runners with matching tests.Reviewed by Cursor Bugbot for commit 1d6223b. Bugbot is set up for automated code reviews on this repo. Configure here.