null_blk: initialize lock mutex before registering configfs subsystem#1031
Open
blktests-ci[bot] wants to merge 1 commit into
Open
null_blk: initialize lock mutex before registering configfs subsystem#1031blktests-ci[bot] wants to merge 1 commit into
blktests-ci[bot] wants to merge 1 commit into
Conversation
Author
|
Upstream branch: 87320be |
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
July 6, 2026 08:28
d52f35a to
a644c13
Compare
Author
|
Upstream branch: 8cdeaa5 |
blktests-ci
Bot
force-pushed
the
series/1121484=>linus-master
branch
from
July 6, 2026 09:02
bc0dd20 to
6986b1c
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
July 7, 2026 08:33
a644c13 to
a2204c3
Compare
Author
|
Upstream branch: 0e35b9b |
In null_init(), mutex_init(&lock) currently happens after configfs_register_subsystem(), which exposes the nullb subsystem to userspace. A racing mkdir() into /sys/kernel/config/nullb/ can reach null_find_dev_by_name() -> mutex_lock(&lock) before the mutex is initialized, trigger warning: [ 123.137788] DEBUG_LOCKS_WARN_ON(lock->magic != lock) [ 123.137796] WARNING: kernel/locking/mutex.c:159 at mutex_lock+0x171/0x1c0, CPU#13: mkdir/1301 [ 123.140090] Modules linked in: null_blk(+) nft_fib_inet nft_fib_ipv4 ...... [ 123.154926] Call Trace: [ 123.155172] <TASK> [ 123.155419] ? __pfx_mutex_lock+0x10/0x10 [ 123.156181] ? __pfx__raw_spin_lock+0x10/0x10 [ 123.156571] nullb_group_make_group+0x20/0x100 [null_blk] [ 123.157011] configfs_mkdir+0x47b/0xc70 [ 123.157337] ? __pfx_configfs_mkdir+0x10/0x10 [ 123.157719] ? may_create_dentry+0x242/0x2e0 [ 123.158061] vfs_mkdir+0x2a9/0x6c0 [ 123.158352] filename_mkdirat+0x3dc/0x500 [ 123.158710] ? __pfx_filename_mkdirat+0x10/0x10 [ 123.159070] ? strncpy_from_user+0x3a/0x1d0 [ 123.159413] __x64_sys_mkdir+0x6b/0x90 [ 123.159760] do_syscall_64+0xea/0x600 Move mutex_init(&lock) before configfs_register_subsystem(). Fixes: 49c3b92 ("block: null_blk: Improve device creation with configfs") Signed-off-by: Zizhi Wo <wozizhi@huawei.com>
blktests-ci
Bot
force-pushed
the
series/1121484=>linus-master
branch
from
July 7, 2026 08:44
6986b1c to
a9ba345
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: null_blk: initialize lock mutex before registering configfs subsystem
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1121484