Enable lock context analysis in drivers/block/#947
Open
blktests-ci[bot] wants to merge 27 commits into
Open
Conversation
Author
|
Upstream branch: 8b87d2b |
Author
|
Upstream branch: 8b87d2b |
blktests-ci
Bot
force-pushed
the
series/1108850=>for-next
branch
from
d431b82 to
55a36ea
Compare
Author
|
Upstream branch: 8b87d2b |
blktests-ci
Bot
force-pushed
the
series/1108850=>for-next
branch
from
55a36ea to
d772389
Compare
Author
|
Upstream branch: 8b87d2b |
blktests-ci
Bot
force-pushed
the
series/1108850=>for-next
branch
from
d772389 to
d1a7988
Compare
Author
|
Upstream branch: 8b87d2b |
blktests-ci
Bot
force-pushed
the
series/1108850=>for-next
branch
from
d1a7988 to
28a8671
Compare
blktests-ci
Bot
force-pushed
the
for-next_base
branch
from
108c4f0 to
80c450e
Compare
Author
|
Upstream branch: 8282f98 |
blktests-ci
Bot
force-pushed
the
series/1108850=>for-next
branch
from
28a8671 to
d46f60a
Compare
Author
|
Upstream branch: 8282f98 |
blktests-ci
Bot
force-pushed
the
series/1108850=>for-next
branch
from
d46f60a to
56d19d2
Compare
blktests-ci
Bot
force-pushed
the
for-next_base
branch
from
80c450e to
627050e
Compare
Author
|
Upstream branch: 1d1de89 |
blktests-ci
Bot
force-pushed
the
series/1108850=>for-next
branch
from
56d19d2 to
1253071
Compare
blktests-ci
Bot
force-pushed
the
for-next_base
branch
from
627050e to
e84ed1e
Compare
Author
|
Upstream branch: 5c7804e |
blktests-ci
Bot
force-pushed
the
series/1108850=>for-next
branch
from
1253071 to
8181c0d
Compare
blktests-ci
Bot
force-pushed
the
for-next_base
branch
from
e84ed1e to
af3fc2b
Compare
Author
|
Upstream branch: b9e3062 |
blktests-ci
Bot
force-pushed
the
series/1108850=>for-next
branch
from
8181c0d to
55f441f
Compare
blktests-ci
Bot
force-pushed
the
for-next_base
branch
from
af3fc2b to
39de126
Compare
Author
|
Upstream branch: 523fc0d |
blktests-ci
Bot
force-pushed
the
series/1108850=>for-next
branch
from
55f441f to
d224906
Compare
blktests-ci
Bot
force-pushed
the
for-next_base
branch
from
39de126 to
f48a15a
Compare
blktests-ci
Bot
force-pushed
the
for-next_base
branch
from
fdcf345 to
e0cbfee
Compare
Add a missing __must_hold() annotation. Enable lock context analysis in the Makefile. Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Md Haris Iqbal <haris.iqbal@linux.dev>
The "extern" keyword is superfluous when declaring a function. Remove that keyword from function definitions to improve consistency with the rest of the kernel source code. Suggested-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Christoph Hellwig <hch@lst.de>
There are two slightly different _get_ldev_if_state() implementations in the DRBD source code. Keep the version that is used. This does not affect C=1 / C=2 builds because lock context checking is performed by Clang instead of sparse since commit 5b63d0a ("compiler-context- analysis: Remove Sparse support"). Signed-off-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Christoph Hellwig <hch@lst.de>
The get_ldev_if_state() macro has been introduced because sparse does not support something like __cond_acquires(). Remove this macro and rename _get_ldev_if_state() into get_ldev_if_state(). Signed-off-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Christoph Hellwig <hch@lst.de>
The 'local' lock context represents code sections between get_ldev() and put_ldev() calls. Between these two calls the device->ldev pointer is valid. Since there are multiple functions with unpaired get_ldev() / put_ldev() calls, remove this lock context. Signed-off-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Christoph Hellwig <hch@lst.de>
Call mutex_lock() instead of mutex_trylock() followed by mutex_lock().
Remove the code that depends on device->bitmap == NULL because this
can't happen. All drbd_bm_{lock,unlock}() callers guarantee that the
device->bitmap pointer is valid.
Suggested-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Move the resources_mutex declaration in front of the functions that acquire and release this mutex. Move the drbd_wait_misc() declaration past the struct drbd_device definition. This patch prepares for adding lock context annotations. Signed-off-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Christoph Hellwig <hch@lst.de>
Prepare for adding lock context annotations. Without this change, an __assume_ctx_lock() statement would have to be added. Signed-off-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Christoph Hellwig <hch@lst.de>
Move the code between the 'put_result' and 'out' labels into a new function. Prepare for making the following code unconditional: if (resource) mutex_unlock(&resource->conf_update); Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Only jump to the 'out' label if resource is not NULL such that the mutex_unlock() call past the 'out' label can be made unconditional. Signed-off-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Christoph Hellwig <hch@lst.de>
Move all code except a mutex_lock() and a mutex_unlock() call from drbd_req_state() into the new function __drbd_req_state(). This patch prepares for adding a second __drbd_req_state() caller. Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Prepare for enabling lock context analysis. Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Annotate the bitmap locking functions. Introduce a new token context lock because the struct drbd_device definition is not visible from the drbd_int.h header file. Annotate the declarations of bitmap locking functions with only the token context lock. Annotate the definitions of the bitmap locking functions with both the token context lock and the actual mutex. Signed-off-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Christoph Hellwig <hch@lst.de>
Clang performs more strict checking of lock context annotations than sparse. This patch makes the DRBD lock context annotations compatible with Clang and enables lock context analysis in the Makefile. Cc: Christoph Böhmwalder <christoph.boehmwalder@linbit.com> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Prepare for adding a second call of __loop_change_fd(). Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Prepare for adding a second __loop_configure() call. Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Keep the behavior in loop_global_lock_killable() for the global == true case. Expand loop_global_lock_killable(lo, false) calls into a mutex_lock_killable() and a mutex_unlock() call. Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Add lock context annotations that are compatible with Clang. Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Let the compiler verify lock and unlock calls. Enable lock context analysis in the Makefile. Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Add the missing __must_hold() annotations. Enable lock context analysis in the Makefile. Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Add __must_hold() annotations where these are missing. Annotate two functions that use conditional locking with __context_unsafe(). Enable lock context analysis in the Makefile. Signed-off-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Damien Le Moal <dlemoal@kernel.org> Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
Add lock context annotations and enable lock context analysis. Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Add the lock context annotations that are required by Clang. Signed-off-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Ming Lei <tom.leiming@gmail.com>
Let Clang verify lock and unlock calls. Enable lock context analysis in the Makefile. Acked-by: Roger Pau Monné <roger.pau@citrix.com> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Author
|
Upstream branch: 54740e4 |
Add the lock context annotations that are required by Clang. Enable lock context analysis in the Makefile. Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Let Clang verify lock and unlock calls. Enable lock context analysis in the Makefile. Acked-by: Jack Wang <jinpu.wang@ionos.com> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Now that all locking functions in block drivers have been annotated, enable lock context analysis for all block drivers at the top level of drivers/block/. Signed-off-by: Bart Van Assche <bvanassche@acm.org>
blktests-ci
Bot
force-pushed
the
series/1108850=>for-next
branch
from
4c79a4a to
8989b71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: Enable lock context analysis in drivers/block/
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1108850