tree: replace strdup with xstrdup in nvme_alloc_subsystem()#3518
Merged
Conversation
Collaborator
|
Could you merge the two patches into one. Thanks! |
Replace strdup() with xstrdup() when duplicating the subsystem NQN. Unlike strdup(), xstrdup() safely returns NULL when passed a NULL pointer, avoiding undefined behavior if subsysnqn is NULL. Also check the return value from xstrdup() and bail out early if duplicating the subsystem NQN fails, either because the input pointer is NULL or because memory allocation was unsuccessful. This issue was reported by the clang static analyzer. Signed-off-by: Sarah Ahmed <sarah.ahmed@ibm.com>
sahmed-ibm
force-pushed
the
fix-null-strdup-subsysnqn
branch
from
04f1951 to
d4f425a
Compare
Contributor
Author
|
Sure! |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace strdup() with xstrdup() when duplicating the subsystem NQN.
Unlike strdup(), xstrdup() safely returns NULL when passed a NULL
pointer, avoiding undefined behavior if subsysnqn is NULL.
Also check the return value from xstrdup() and bail out early if
duplicating the subsystem NQN fails, either because the input pointer
is NULL or because memory allocation was unsuccessful.
This issue was reported by the clang static analyzer.
Signed-off-by: Sarah Ahmed sarah.ahmed@ibm.com