plugins/wdc: fix typed malloc size expressions for log buffers#3526
Merged
Conversation
bellis-ibm
force-pushed
the
fix-plugins-wdc-sizeof
branch
from
956e7d8 to
289f6c7
Compare
Use pointee-sized allocations for structured log buffers in nvme_get_hw_rev_log() and nvme_get_print_ocp_cloud_smart_log(), and simplify raw byte-buffer allocation in wdc_enc_submit_move_data(). This eliminates clang-analyzer allocator-size mismatch warnings and improves maintainability by typing allocation sizes directly to the destination pointer type. Signed-off-by: Brooke Ellis <Brooke.Ellis@ibm.com>
igaw
force-pushed
the
fix-plugins-wdc-sizeof
branch
from
289f6c7 to
fd26c95
Compare
Collaborator
|
reformatted commit message. |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use pointee-sized allocations for structured log buffers in
nvme_get_hw_rev_log() and nvme_get_print_ocp_cloud_smart_log(),
and simplify raw byte-buffer allocation in wdc_enc_submit_move_data().
This eliminates clang-analyzer allocator-size mismatch warnings and
improves maintainability by typing allocation sizes directly
to the destination pointer type.
Signed-off-by: Brooke Ellis Brooke.Ellis@ibm.com