Embed Prism dashboard in docs and fix missing sidebar item#280
Conversation
jjk-g
requested review from
Gregory-Pereira,
chcost,
clubanderson,
davidgs,
jjasghar,
petecheslock,
robertgshaw2-redhat and
smarterclayton
as code owners
✅ Deploy Preview for elaborate-kangaroo-25e1ee ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Needs DCO sign-off |
jjk-g
changed the title
|
DCO updated |
|
Hey @jjk-g if you give this a rebase and fix the conflicts this should end up getting a clean CI run and we can get this reviewed/merged. |
jjk-g
force-pushed
the
main
branch
2 times, most recently
from
c3e9c69 to
424d67b
Compare
Signed-off-by: jjk-g <jkramberger@google.com>
Signed-off-by: jjk-g <jkramberger@google.com>
|
@petecheslock should be ready for review |
|
The embedded dashboard in the versioned location looks fine - https://deploy-preview-280--elaborate-kangaroo-25e1ee.netlify.app/docs/guides/optimized-baseline But the one under dev looks like it just clobbered all the data. https://deploy-preview-280--elaborate-kangaroo-25e1ee.netlify.app/docs/dev/guides/optimized-baseline |
|
Also the build failure is based on these broken links which are fixed in #332 |
|
@dependabot rebase |
|
This PR is marked as stale after 21d of inactivity. After an additional 14d of inactivity (7d to become rotten, then 7d more), it will be closed. To prevent this PR from being closed, add a comment or remove the |
|
@jjk-g Please resolve the conflicts ASAP before this is is marked rotten |
3 participants
What does this PR do?
At build time this appends a "Results Dashboard" section to the optimized-baseline guide with a blurb and iframe that embeds the corresponding Prism dashboard.
Why is this change needed?
Adds Prism links to the documentation.
How was this tested?
npm test)npm run build)npm start)Checklist
git commit -s) per DCOnpm test)npm run build)Related Issues