fix: allow separate input/output budgets for T5 in context check#3885
Open
Chessing234 wants to merge 1 commit into
Open
fix: allow separate input/output budgets for T5 in context check#3885Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1711.
FastChat-T5 supports up to 2K encoder tokens plus 2K decoder tokens, but the OpenAI API server treated context as a single shared budget (
context_len - prompt_tokens).Root cause
check_lengthalways used the causal-LM formula, so a 1790-token prompt withmax_tokens=512was rejected as 2302 > 2048 even though T5 can encode 1790 tokens and still generate 512 more.Fix
For T5 models, validate prompt length against
context_lenand cap completion tokens independently, matching encoder-decoder behavior ininference.py.Test plan
fastchat-t5-3b-v1.0, ~1790 prompt tokens, andmax_tokens=512; request should succeedMade with Cursor