ESM-only#4542
Conversation
|
Tests pass locally for me. @lovell can you run the workflows? |
|
@lovell I think I fixed everything (coverage and node 20), should be good to go |
|
I just tried running the failing tests locally on Windows 11 and can't replicate, so I think that they should pass now that lint is fixed, but no guarantee :/ |
|
I think the issue was around the font file so I tried another approach of having the font file directly in the repo. I tried it locally on windows 11 and it worked but again, no guarantee. If that doesn't work, I'm out of ideas |
|
It worked 🎉 |
| @@ -4,7 +4,7 @@ | |||
| */ | |||
|
|
|||
| import color from '@img/colour'; | |||
There was a problem hiding this comment.
@img/colour is essentially the CommonJS version of the color package:
This package converts the color package and its dependencies, all of which are MIT-licensed, to CommonJS.
Since sharp is now ESM-only, this seems like a good time to migrate to color directly.
There was a problem hiding this comment.
I'll let Lovell decide but I think it makes sense
There was a problem hiding this comment.
For context I also opened e18e/module-replacements#786 about it
Closes #4539