Skip to content

fix catastrophic backtracking in jquery typesMap rule #63536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dxbjavid wants to merge 1 commit into from
+1 −1
Closed

fix catastrophic backtracking in jquery typesMap rule #63536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/server/typesMap.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"typesMap": {
"jquery": {
"match": "jquery(-(\\.?\\d+)+)?(\\.intellisense)?(\\.min)?\\.js$",
"match": "jquery(-[\\d.]+)?(\\.intellisense)?(\\.min)?\\.js$",
Copy link
Copy Markdown
Author

@dxbjavid dxbjavid Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentionally matching the in-code defaultTypeSafeList in editorServices.ts, which already uses [\d.]+ for the same jquery entry. The shipped map and the in-code rule are meant to be identical and had drifted, so I kept the bracket class rather than introduce a third variant. The looser dot handling you point out is already how the in-code rule behaves, and for filename-based type acquisition over-matching just means jquery types get pulled in for an oddly named file, which is harmless. The thing I'm fixing here is the nested (\.?\d+)+ quantifier that backtracks exponentially.

"types": ["jquery"]
},
"WinJS": {
Expand Down