Skip to content

Build(deps-dev): Bump pyright from 1.1.408 to 1.1.410 in /python#6275

Closed
dependabot[bot] wants to merge 4 commits into
mainfrom
dependabot/pip/python/pyright-1.1.410
Closed

Build(deps-dev): Bump pyright from 1.1.408 to 1.1.410 in /python#6275
dependabot[bot] wants to merge 4 commits into
mainfrom
dependabot/pip/python/pyright-1.1.410

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 2, 2026

Copy link
Copy Markdown
Contributor

Bumps pyright from 1.1.408 to 1.1.410.

Commits

@dependabot dependabot Bot added dependencies python Issues related to the Python codebase labels Jun 2, 2026
Copilot AI review requested due to automatic review settings June 2, 2026 19:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions github-actions Bot changed the title Build(deps-dev): Bump pyright from 1.1.408 to 1.1.410 in /python Python: Build(deps-dev): Bump pyright from 1.1.408 to 1.1.410 in /python Jun 2, 2026
@dependabot dependabot Bot changed the title Python: Build(deps-dev): Bump pyright from 1.1.408 to 1.1.410 in /python Build(deps-dev): Bump pyright from 1.1.408 to 1.1.410 in /python Jun 4, 2026
@dependabot dependabot Bot force-pushed the dependabot/pip/python/pyright-1.1.410 branch from 6c342f4 to 6870f67 Compare June 4, 2026 23:14
Bumps [pyright](https://github.com/RobertCraigie/pyright-python) from 1.1.408 to 1.1.410.
- [Release notes](https://github.com/RobertCraigie/pyright-python/releases)
- [Commits](RobertCraigie/pyright-python@v1.1.408...v1.1.410)

---
updated-dependencies:
- dependency-name: pyright
  dependency-version: 1.1.410
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/pip/python/pyright-1.1.410 branch from 6870f67 to 838b20d Compare June 9, 2026 21:37
@moonbox3

Copy link
Copy Markdown
Contributor

@copilot: fix the CI/CD failures

Copilot AI commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@copilot: fix the CI/CD failures

Fixed in commit 9c78e3a. I investigated the failing workflow logs and resolved the root cause by aligning pyright pinning across the Python workspace (python/packages/lab/pyproject.toml) and regenerating python/uv.lock, which removes the dependency resolution conflict in CI setup.

Copilot AI requested a review from moonbox3 June 17, 2026 01:20
@moonbox3 moonbox3 added the lab label Jun 17, 2026
@moonbox3

Copy link
Copy Markdown
Contributor

@copilot: fix the remaining CI/CD failures. Package Checks (3.11) is failing under pyright 1.1.410. The failed pyright package checks are: packages/redis (agent_framework_redis/context_provider.py: operator.and is partially unknown and reduce receives an unknown function type), packages/core (agent_framework/_types.py assignment type issue in ResponseStream and agent_framework/_workflows/_events.py @contextmanager return annotation should use Generator), packages/anthropic (AsyncAnthropicBedrock / AsyncAnthropicVertex private import usage from anthropic; import from ._client instead), and packages/orchestrations (agent_framework_orchestrations/_magentic.py passes UNSET where int | Sentinel is expected). merge-gatekeeper is failing only because Package Checks is red.

Copilot AI commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@copilot: fix the remaining CI/CD failures. Package Checks (3.11) is failing under pyright 1.1.410. The failed pyright package checks are: packages/redis (agent_framework_redis/_context_provider.py: o...

Implemented in commits 163ffab and c653f05. I fixed the remaining pyright 1.1.410 Package Checks failures in packages/redis, packages/core, packages/anthropic, and packages/orchestrations, and validated with targeted package pyright runs (core, redis, anthropic, orchestrations) now all passing.

@eavanvalkenburg

Copy link
Copy Markdown
Member

closing in favor of #6443

@dependabot @github

dependabot Bot commented on behalf of github Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot Bot deleted the dependabot/pip/python/pyright-1.1.410 branch June 18, 2026 10:26
eavanvalkenburg added a commit to eavanvalkenburg/agent-framework that referenced this pull request Jun 18, 2026
Pyright 1.1.410 tightened several checks. Apply the same source fixes as
upstream PR microsoft#6275:

- anthropic: import AsyncAnthropicBedrock from anthropic.lib.bedrock and
  AsyncAnthropicVertex from anthropic.lib.vertex (no longer re-exported from
  the anthropic top-level package -> reportPrivateImportUsage).
- core _types.py: cast the transform-hook result to UpdateT (reportAssignmentType).
- core _workflows/_events.py: annotate the @contextmanager helper as
  Generator[None] instead of Iterator[None] (reportDeprecated).
- redis: build the combined filter expression with an explicit loop instead of
  reduce(and_, ...), which pyright could no longer fully type (drops the now
  unused functools.reduce / operator.and_ imports).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
westey-m pushed a commit to westey-m/agent-framework that referenced this pull request Jun 18, 2026
…tests/samples) (microsoft#6443)

* Python: Split type checkers by target (pyright source, 5 checkers on tests/samples)

Rework the typing setup along the lines of the 'too many type checkers'
approach:

- Pyright (strict) is now the sole source-code type checker; mypy is
  removed from source and its [tool.mypy] block becomes a relaxed profile
  used only for tests/samples.
- Tests are checked by all five checkers (pyright relaxed, mypy, pyrefly,
  ty, zuban); samples by pyright, pyrefly, and ty. All run in a relaxed/
  basic profile so authors aren't forced into over-annotation.
- Add pyrightconfig.tests.json and bump sample pyright configs to basic.
- Unify test/sample typing onto the same parallel fan-out used by source
  pyright via run_command_items in task_runner.py.
- Make version-conditional imports symmetric: keep or drop the
  '# type: ignore' on both branches so results match across interpreter
  versions (local vs CI).
- Update SKILL.md, DEV_SETUP.md, and CODING_STANDARD.md for the five
  gating checkers and pyright on source+tests+samples.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Python: Fix merge regressions from main (typing + runtime)

Merging main into the type-checker split branch surfaced regressions that
the new five-checker test suite and unit tests caught:

Runtime fixes:
- anthropic: restore the dropped `cache_read_input_token_count` mapping in
  _parse_usage_from_anthropic (lost during merge conflict resolution).
- gemini: _get_function_calling_mode test helper returned str(enum)
  ('FunctionCallingConfigMode.AUTO') instead of the enum value ('AUTO').
- openai: _response_id_from_token test helper was an infinite self-recursion;
  return token['response_id'].
- orchestrations: reset output_events per approval iteration so the terminal
  output assertion counts only the final run.
- core: drop a stale duplicate harness test whose message ('non-negative')
  contradicted the source ('positive').
- purview: import PolicyLocation/PolicyScope/ProtectionScopeActivities/
  ExecutionMode used by the processor tests.

Type-checker fixes (tests, relaxed profile):
- core: pyright/mypy/pyrefly/ty/zuban green-ups across the harness, MCP,
  observability and types tests.
- anthropic/openai: route provider-namespaced UsageDetails keys through a
  dict cast (extra_items TypedDict unsupported by mypy/ty).
- purview: typed model constructors and cache-mock casts.
- ag-ui: annotate WorkflowContext[Any, Any] so yield_output accepts test
  payloads, guard Optional forwarded_props, and ty-ignore intentional bad args.

Source pyright (sole source checker) flagged unnecessary ignores newly
introduced by merged code in core _tools.py and declarative _declarative_base.py.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Python: Isolate per-package mypy cache in test-typing fan-out

The parallel test-typing fan-out runs many mypy processes concurrently,
all defaulting to a single shared ./.mypy_cache. Concurrent writes corrupt
the cache and mypy aborts with INTERNAL ERROR (intermittently, depending on
worker timing) -- which is why CI's Test Typing job failed on a shifting set
of packages while a single-package run was fine.

Give each mypy invocation an isolated cache dir keyed by its target paths so
incremental caching still works per package without races. Other checkers
(zuban/pyrefly/ty/pyright) maintain their own caches and are unaffected.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Python: Make lab pyright-only on source (drop source mypy)

Lab was the last package still running mypy on its source code, requiring
mypy-only `# type: ignore` comments that pyright (the sole source checker
everywhere else) flags as unnecessary. Align lab with the rest of the
monorepo:

- Remove the lab source mypy poe tasks (mypy-gaia/lightning/tau2) and the
  now-dead strict [tool.mypy] config block.
- Drop the 'Run lab mypy' CI step; lab source is type-checked by pyright only.

Lab tests remain covered by the workspace test-typing fan-out (mypy, pyrefly,
ty, zuban, pyright over tests using the relaxed root config).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Python: Fix test-typing regressions from latest main merge

A fresh merge from main brought in new test code never run under the
five-checker test-typing suite. Green up across the affected packages:

- core: narrow Optional span.attributes with 'and' guards in span filters
  and assert+cast the json.loads(...attributes[...]) reads (test_observability);
  match the existing as_agent ignore on the protocol-typed fixture (test_clients).
- openai: align new streaming tests with the established chat_options dict
  pattern (ChatOptions TypedDict isn't assignable to dict), route Optional
  .annotations[0] access through a small _first_annotation helper (mirrors the
  file's assert-not-None convention), and annotate a mapped ResponseStream.
- foundry_hosting: annotate error: dict[str, Any] = body.get(...) or {}
  (zuban needs the annotation).
- foundry: narrow ignores for the live AIProjectClient credential arg (pyrefly)
  and connections.get_default (zuban) SDK type gaps.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* updated pyright version

* pyright fix

* Python: Fix source typing for pyright 1.1.410

Pyright 1.1.410 tightened several checks. Apply the same source fixes as
upstream PR microsoft#6275:

- anthropic: import AsyncAnthropicBedrock from anthropic.lib.bedrock and
  AsyncAnthropicVertex from anthropic.lib.vertex (no longer re-exported from
  the anthropic top-level package -> reportPrivateImportUsage).
- core _types.py: cast the transform-hook result to UpdateT (reportAssignmentType).
- core _workflows/_events.py: annotate the @contextmanager helper as
  Generator[None] instead of Iterator[None] (reportDeprecated).
- redis: build the combined filter expression with an explicit loop instead of
  reduce(and_, ...), which pyright could no longer fully type (drops the now
  unused functools.reduce / operator.and_ imports).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Python: Accept plain-text body in Azure Functions workflow/run endpoint

The workflow_orchestrator already accepts plain strings as well as JSON
objects via context.get_input(), but the start_workflow_orchestration HTTP
handler only accepted JSON and returned 400 for any non-JSON body. This made
the functions integration tests that POST text/plain to /api/workflow/run
(e.g. test_09_workflow_shared_state) fail consistently with 400 != 202.

Fall back to the raw request body (decoded as UTF-8) when the body is not
JSON, rejecting only a truly empty body. The JSON path is unchanged.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Issues related to the Python codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants