Skip to content

glycin: make optional loader cleanup resilient in %prep#17657

Draft
Copilot wants to merge 2 commits into
4.0from
copilot/fix-code-review-suggestion
Draft

glycin: make optional loader cleanup resilient in %prep#17657
Copilot wants to merge 2 commits into
4.0from
copilot/fix-code-review-suggestion

Conversation

Copilot AI commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

This addresses the linked review comment requesting safer removal of optional loader directories in glycin.spec. The %prep cleanup now tolerates upstream layout drift instead of failing when a loader directory is missing.

  • What changed

    • Updated loader cleanup commands in specs/g/glycin/glycin.spec to use forceful recursive removal for optional directories:
      • glycin-loaders/glycin-raw
      • glycin-loaders/glycin-jpeg2000
  • Why this matters

    • Keeps %prep robust when those workspace members are renamed/removed upstream while preserving the intent to exclude them.
# before
rm -r glycin-loaders/glycin-raw
rm -r glycin-loaders/glycin-jpeg2000

# after
rm -rf glycin-loaders/glycin-raw
rm -rf glycin-loaders/glycin-jpeg2000

Copilot AI changed the title [WIP] Fix code based on review comment glycin: make optional loader cleanup resilient in %prep Jun 9, 2026
Copilot AI requested a review from WithEnoughCoffee June 9, 2026 02:51
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Hello, and thank you for opening this pull request! 👋🏼 We appreciate the contribution.

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Commits in this repo will typically be prefixed with fix:, feat:, docs:, chore:, refactor:, test:, or ci: to indicate the type of change being proposed. The linked specification has more details.

Details:

Unknown release type "glycin" found in pull request title "glycin: make optional loader cleanup resilient in `%prep`".

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

📄❌ Rendered specs are out of date

FIX: — run this and commit the result:

azldev component render glycin

Or download the fix patch and apply it:

gh run download 27180741641 -R microsoft/azurelinux -n rendered-specs-patch
git apply rendered-specs.patch
Category Count
Content diffs 1
Extra files (untracked) 0
Missing files (deleted) 0

Content diffs

`specs/g/glycin/glycin.spec`
--- committed/specs/g/glycin/glycin.spec
+++ rendered/specs/g/glycin/glycin.spec
@@ -186,9 +186,9 @@
 %endif
 
 # drop glycin-raw loader (missing dependencies, not enabled by default)
-rm -rf glycin-loaders/glycin-raw
+rm -r glycin-loaders/glycin-raw
 # drop glycin-jpeg2000 loader (missing dependencies, not enabled by default)
-rm -rf glycin-loaders/glycin-jpeg2000
+rm -r glycin-loaders/glycin-jpeg2000
 
 
 %if %{without bundled_rust_deps}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants