glycin: make optional loader cleanup resilient in %prep#17657
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on review comment
glycin: make optional loader cleanup resilient in Jun 9, 2026
%prep
|
Hello, and thank you for opening this pull request! 👋🏼 We appreciate the contribution. We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Commits in this repo will typically be prefixed with Details: |
📄❌ Rendered specs are out of dateFIX: — run this and commit the result: azldev component render glycinOr download the fix patch and apply it: gh run download 27180741641 -R microsoft/azurelinux -n rendered-specs-patch
git apply rendered-specs.patch
Content diffs`specs/g/glycin/glycin.spec`--- committed/specs/g/glycin/glycin.spec
+++ rendered/specs/g/glycin/glycin.spec
@@ -186,9 +186,9 @@
%endif
# drop glycin-raw loader (missing dependencies, not enabled by default)
-rm -rf glycin-loaders/glycin-raw
+rm -r glycin-loaders/glycin-raw
# drop glycin-jpeg2000 loader (missing dependencies, not enabled by default)
-rm -rf glycin-loaders/glycin-jpeg2000
+rm -r glycin-loaders/glycin-jpeg2000
%if %{without bundled_rust_deps}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the linked review comment requesting safer removal of optional loader directories in
glycin.spec. The%prepcleanup now tolerates upstream layout drift instead of failing when a loader directory is missing.What changed
specs/g/glycin/glycin.specto use forceful recursive removal for optional directories:glycin-loaders/glycin-rawglycin-loaders/glycin-jpeg2000Why this matters
%preprobust when those workspace members are renamed/removed upstream while preserving the intent to exclude them.