You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Enum insertion point changed — New status codes (LDNS_STATUS_ID_DID_NOT_MATCH, LDNS_STATUS_QDCOUNT_MUST_BE_ONE, LDNS_STATUS_QUERY_DID_NOT_MATCH) are appended after LDNS_STATUS_INVALID_SVCPARAM_VALUE (last entry in 1.8.3) instead of after LDNS_STATUS_EQUAL_RR which only exists in newer versions.
TXID matching hunk omitted — The original commit changes an existing TXID check (printf("wrong TXID!\n") → LDNS_STATUS_ID_DID_NOT_MATCH) and updates a return path (LDNS_STATUS_ERR → status ? status : LDNS_STATUS_ERR). This entire code path does not exist in 1.8.3, so the hunk is not applicable.
LDNS_STATUS_ID_DID_NOT_MATCH defined but unused — The enum value is still added for ABI consistency with upstream, but no code references it in 1.8.3 since the TXID verification logic was introduced in a later release.
What was preserved as-is:
QDCOUNT validation at ldns_send_buffer() entry (rejects queries without exactly one question)
Response question section matching before returning result (verifies response matches query)
All three new error codes and their human-readable strings in error.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto Patch ldns for CVE-2026-10846.
Autosec pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1136624&view=results
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology