Fail sub-orchestration fast when its instance id is already terminal#28
Open
tjgreen42 wants to merge 1 commit into
Open
Fail sub-orchestration fast when its instance id is already terminal#28tjgreen42 wants to merge 1 commit into
tjgreen42 wants to merge 1 commit into
Conversation
A sub-orchestration's child instance id is auto-generated as
{parent}::sub::{event_id}. If an instance with that id already exists in a
terminal state, the orchestration dispatcher's terminal fast-ack path discarded
the incoming StartOrchestration without notifying the scheduling parent, leaving
the parent awaiting a completion that never arrived.
The dispatcher now enqueues a SubOrchFailed back to the scheduling parent when a
discarded terminal batch contains a StartOrchestration whose parent differs from
the terminal instance's own recorded parent, so the parent fails fast. Genuine
redelivery of a completed child's start (same parent and id) is left untouched.
Client::start_orchestration and start_orchestration_versioned also now reject
instance ids that use the reserved sub:: marker, so a caller cannot occupy a
future child id. Other uses of :: remain valid.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A sub-orchestration's child instance id is auto-generated as
{parent}::sub::{event_id}. If an instance with that id already existed in a terminal state, the dispatcher's terminal fast-ack path discarded the incoming StartOrchestration without notifying the scheduling parent, so the parent awaited a completion that never arrived and hung.The dispatcher now enqueues a SubOrchFailed back to the scheduling parent whenever a discarded terminal batch contains a StartOrchestration whose parent differs from the terminal instance's own recorded parent. The parent-mismatch check is what keeps ordinary at-least-once redelivery of a completed child's own start (same parent and id) from spuriously re-failing the parent.
As defense in depth, the client start APIs now reject instance ids using the reserved
sub::marker; plain::(e.g.i4::child-1) stays valid. Reuses the existing SubOrchFailed work item and ErrorDetails variant, so mixed-version clusters are unaffected.