fix: change assert tp_idx > 0 to tp_idx >= 0 in TimeAdjuster.truncate()#2245
Open
Whning0513 wants to merge 1 commit into
Open
fix: change assert tp_idx > 0 to tp_idx >= 0 in TimeAdjuster.truncate()#2245Whning0513 wants to merge 1 commit into
Whning0513 wants to merge 1 commit into
Conversation
Fixes microsoft#1610 When start_time in the workflow config exactly matches the first trading day in the calendar, tp_idx is 0, causing the assertion to fail. The >= check handles this edge case without affecting existing behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting
start_timeto a date that happens to be the first trading day inday.txt, the workflow crashes withAssertionErrorinTimeAdjuster.truncate(). The root cause is thattp_idx(the index fromcalendar.searchsorted()) is 0 for the first calendar entry, but the assertion checkstp_idx > 0. Index 0 is a perfectly valid position — the assertion should betp_idx >= 0.Would appreciate a review, thanks!