Vendor dprint plugins#4458
Draft
jakebailey wants to merge 3 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR vendors the dprint formatter WASM plugins into the repo to avoid format/check steps depending on fetching plugins from plugins.dprint.dev (which may fail under stricter network/firewall environments). It also adds a Hereby task to refresh the vendored plugins and records plugin version metadata.
Changes:
- Add a
hereby update:dprint-pluginstask that downloads the latest dprint plugin WASM files and writes_tools/dprint-plugins/versions.json. - Update
.dprint.jsoncto reference the vendored plugin WASM paths under_tools/dprint-plugins/. - Adjust
.gitignoreto allow committing the vendored.wasmfiles and remove the Copilot setup prefetch step that previously pulled dprint caches.
Reviewed changes
Copilot reviewed 4 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Herebyfile.mjs | Adds a task to download/update vendored dprint plugin WASM files and write plugin metadata. |
| .gitignore | Un-ignores the vendored _tools/dprint-plugins/*.wasm files so they can be committed. |
| .github/workflows/copilot-setup-steps.yml | Removes the previous step that attempted to prefetch dprint caches before network restrictions. |
| .dprint.jsonc | Switches dprint plugin configuration from remote URLs to local vendored WASM paths and documents the update task. |
| _tools/dprint-plugins/versions.json | Introduces metadata (version/checksum/url) for the vendored plugins. |
# Conflicts: # .dprint.jsonc
Member
Author
|
dprint is getting "plugins via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We depend on these in our build for generated code. But, we are likely to hit firewall problems in the future since they get pulled from
plugins.dprint.dev.Instead, vendor copies in the repo, and add a script that can update them.