Run symbol-returning completion on the API checker#4480
Merged
andrewbranch merged 1 commit intoJun 30, 2026
Conversation
Set CheckerLifetimeAPI in handleGetCompletionsAtPosition so completion symbols resolve on the same checker GetTypeOfSymbol uses, fixing a nil-pointer panic (e.g. `people.` where `people: string[]`). Document the rule on setupLanguageService and add a regression test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a nil-pointer panic caused by completion entries returning symbol handles created on an ephemeral checker, which later became unresolvable when clients re-queried symbol types on the persistent API checker. It ensures symbol-producing completions run under CheckerLifetimeAPI, documents the lifecycle rule for setupLanguageService, and adds a regression test.
Changes:
- Documented how
setupLanguageService’s internal checker acquisition interacts with symbol/type handle resolvability and the API checker lifetime. - Updated
handleGetCompletionsAtPositionto wrap the request context withCheckerLifetimeAPIwhenIncludeSymbolis requested. - Added a regression test that requests completion symbols for
string[]members and verifies their types can be resolved without panicking.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/api/session.go | Pins symbol-returning completion requests to the API checker lifetime and documents when this is safe. |
| internal/api/session_completion_test.go | Adds regression coverage for resolving types of completion-provided symbols (prevents the nil-pointer crash). |
Contributor
Author
|
@microsoft-github-policy-service agree company="JetBrains" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set CheckerLifetimeAPI in handleGetCompletionsAtPosition so completion symbols resolve on the same checker GetTypeOfSymbol uses, fixing a nil-pointer panic (e.g.
people.wherepeople: string[]). Document the rule on setupLanguageService and add a regression test