Add optional array body Spector scenario#10863
Open
ArcturusZhang wants to merge 6 commits into
Open
Conversation
Cover omitted optional array request bodies in the existing type/array Spector group. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
microsoft-github-policy-service
Bot
added
the
lib:http-specs
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
Keep only the omitted optional array body case in the existing type/array group. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
You can try these changes here
|
ArcturusZhang
requested review from
bterlson,
catalinaperalta,
iscai-msft,
markcowl,
timotheeguerin and
witemple-msft
as code owners
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…nto add-optional-array-body-spector
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
microsoft-github-policy-service
Bot
added
the
stale
Contributor
|
Hi @@ArcturusZhang. Your PR has had no update for 14 days and it is marked as a stale PR. If it is not updated within 14 additional days, the PR will automatically be closed. If you want to refresh the PR, please remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds coverage to the existing
type/arraySpector group for optional array request bodies. The new scenario verifies both sending an array body and omitting the optional body entirely.Validation
pnpm exec prettier --write packages/http-specs/specs/type/array/main.tsp packages/http-specs/specs/type/array/mockapi.tspnpm exec tsc -p packages/http-specs/tsconfig.build.jsonpnpm --filter @typespec/http-specs validate-scenariospnpm --filter @typespec/http-specs validate-mock-apis