Honor custom code property replacements in generated ClientSettings.BindCore

[Copilot]

When a generated ClientSettings property is replaced via [CodeGenMember("OriginalName")], the property was correctly dropped but the generated BindCore still assigned to the original (now non-existent) property, producing code that fails to compile.

// CUSTOM
public partial class QueueClientSettings
{
    [CodeGenMember("Url")]
    public Uri QueueUri { get; set; }
}

Previously BindCore emitted this.Url = url; (no longer exists). It now emits this.QueueUri = url; while still reading from the original section["Url"] key.

Changes

• ClientSettingsProvider.GetSettingPropertyName: resolves the effective assignment target by matching the settings type's CanonicalView.Properties on OriginalName, returning the renamed name when a replacement exists.
• configKey separation: threaded an optional configKey through AppendBindingForProperty and all Append*Binding helpers. configKey (original generated name) drives the configuration lookup; propName (possibly renamed) drives the property assignment. Defaults to propName, so existing callers (ClientOptionsProvider, tests) are unchanged.
• BuildMethods: endpoint, required-parameter, and Options bindings now resolve their target name through GetSettingPropertyName, passing the original name as the config key.

Tests

• Added TestBindCoreMethod_HonorsCustomPropertyRename with test data renaming Endpoint → ServiceUri, asserting the assignment uses the renamed property while the config key stays "Endpoint".

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@typespec/http-client-csharp@10903

commit: eccc8c4

[JoshLove-msft]

@copilot resolve merge conflicts

[Copilot]

@copilot resolve merge conflicts

Merged origin/main. The only conflict was in ClientSettingsProviderTests.cs where both branches added a new test at the same spot — kept both (TestBindCoreMethod_HonorsCustomPropertyRename and TestGeneratedSettings_WithCustomizedBindCore). ClientSettingsProvider.cs auto-merged cleanly. All 41 ClientSettingsProviderTests pass.