Add visible focus indicator to MCP elicitation multi-select options#321147
Draft
Copilot wants to merge 2 commits into
Draft
Add visible focus indicator to MCP elicitation multi-select options#321147Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add visible focus indicator for static option list items
Add visible focus indicator to MCP elicitation multi-select options
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the MCP elicitation form (rendered by the chat question carousel), keyboard navigation through multi-select options moved focus with no visible focus indicator, so keyboard users couldn't tell which option was focused (WCAG 2.4.3).
The two selection types manage focus differently:
aria-activedescendant+ the.selectedclass — already visible.role="option"item vialistItems[focusedIndex].focus(). The CSS rule.chat-question-list-item:focus { outline: none }stripped the indicator, leaving focused-but-unchecked items with no visual cue.Changes
chatQuestionCarousel.css: split the combinedoutline: nonerule. The list container still suppresses its outline (relies onaria-activedescendant), while focused list items now render a--vscode-focusBorderoutline:Uses the standard focus-border token (consistent with the freeform textarea styling in the same file), so high-contrast and custom themes are respected. Single-select is unaffected since its items never take direct DOM focus.