fix #320774#321173
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #320774 in the Agents window by making the “New Session / New Chat” flow (Cmd/Ctrl+N and the Sessions sidebar “New” button) inherit the currently active session’s workspace, so the new-session composer starts with the same workspace preselected.
Changes:
- Route the Sessions view “New” button through the registered command (
workbench.action.sessions.newChat) instead of calling services directly. - Update the
workbench.action.sessions.newChataction to open the new-session composer withfolderUriset from the active session’s workspace URI. - Centralize the command id string into a shared constant.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/sessions/browser/views/sessionsView.ts | Uses ICommandService + shared action id constant to trigger the “New Chat” command from the Sessions view button and to resolve its keybinding hint. |
| src/vs/sessions/contrib/chat/common/constants.ts | Introduces NEW_SESSION_ACTION_ID constant for reuse across contributions. |
| src/vs/sessions/contrib/chat/browser/chat.contribution.ts | Updates the Cmd/Ctrl+N action to pass the active session workspace URI into openNewSession(...), enabling workspace inheritance. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 3
Comment on lines
67
to
71
| override run(accessor: ServicesAccessor): void { | ||
| const sessionsManagementService = accessor.get(ISessionsManagementService); | ||
| const sessionsViewService = accessor.get(ISessionsViewService); | ||
| const sessionsPartService = accessor.get(ISessionsPartService); | ||
| sessionsViewService.openNewSession(); | ||
| sessionsPartService.focusSession(sessionsManagementService.activeSession.get()); | ||
| sessionsViewService.openNewSession({ folderUri: sessionsManagementService.activeSession.get()?.workspace.get()?.uri }); | ||
| } |
Comment on lines
12
to
13
| import { ISessionsManagementService } from '../../../services/sessions/common/sessionsManagement.js'; | ||
| import { ISessionsPartService } from '../../../services/sessions/browser/sessionsPartService.js'; | ||
| import { ISessionsViewService } from '../../../services/sessions/browser/sessionsViewService.js'; |
| const sessionsPartService = accessor.get(ISessionsPartService); | ||
| sessionsViewService.openNewSession(); | ||
| sessionsPartService.focusSession(sessionsManagementService.activeSession.get()); | ||
| sessionsViewService.openNewSession({ folderUri: sessionsManagementService.activeSession.get()?.workspace.get()?.uri }); |
Yoyokrazy
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #320774