Skip to content

Detect openjdks#9

Open
akuhtz wants to merge 3 commits into
mirror:masterfrom
akuhtz:detect-openjdks
Open

Detect openjdks#9
akuhtz wants to merge 3 commits into
mirror:masterfrom
akuhtz:detect-openjdks

Conversation

@akuhtz

@akuhtz akuhtz commented Jun 14, 2019

Copy link
Copy Markdown

This PR allows to detect the following OpenJDKs installation from the Windows registry:

  • Amazon Coretto
  • AdoptOpenJDK
  • Liberica

@VirtualTim

Copy link
Copy Markdown

I assume this makes #7 redundant.

Anyway, this is nice, and hopefully will be merged soon. It seems like this issue affects heaps of users.
Personally I think falling back to %JAVA_HOME% would be better, but if this isn't the direction the project wants to go in this PR seems to also be good.

@teras

teras commented Jun 28, 2019

Copy link
Copy Markdown

Hello, is there any compiled version of this PR or any ideas if this would be embedded?
Thank you

@akuhtz

akuhtz commented Jul 1, 2019

Copy link
Copy Markdown
Author

@teras Which OS do you use for the build?

@VirtualTim

Copy link
Copy Markdown

I'm sure there's many people who would appreciate 32/64 bit, Windows 10 / Server 2016 / Server 2019 builds.

@teras

teras commented Jul 1, 2019

Copy link
Copy Markdown

EDIT

@akuhtz I am using Linux & OSX, mainly OSX.

@VirtualTim

Copy link
Copy Markdown

Just to give some feedback, I've set up our builds with this patch and everything seems to work as expected. Testing has been done with Java 8 and 11.

@chutch1122

Copy link
Copy Markdown

Is this going to be released any time soon?

@iyh

iyh commented Mar 18, 2020

Copy link
Copy Markdown

just respect JAVA_HOME environment variable please...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants