Fix float8_e4m3fnuz input scaling range#1528
Open
maskyuanzh wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the FP8 linear layer implementation in diffsynth/core/vram/layers.py to dynamically determine the maximum representable value for the selected FP8 data type using torch.finfo(self.computation_dtype).max, replacing the previous hardcoded values and conditional logic. No review comments were provided, and there is no additional feedback.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
diffsynth/core/vram/layers.py,AutoWrappedLinear.fp8_linear()currently initializes the FP8 input scaling threshold to 448 and divides it by 2 fortorch.float8_e4m3fnuz:This produces a threshold of 224, while the maximum finite value defined for
torch.float8_e4m3fnuzis 240.This PR replaces the manually derived threshold with the maximum finite value defined by the selected dtype:
As a result:
torch.float8_e4m3fncontinues to use 448.torch.float8_e4m3fnuznow uses 240 instead of 224.Scaling behavior
Let (M) be the maximum absolute value of an input row. For
torch.float8_e4m3fnuz, the old and new scales are:Therefore:
torch.float8_e4m3fnuzis used.