Skip to content

Expose disabled linter rules#3782

Open
giri256 wants to merge 1 commit into
mozilla:masterfrom
giri256:feat/disable-linter-rules-3333
Open

Expose disabled linter rules#3782
giri256 wants to merge 1 commit into
mozilla:masterfrom
giri256:feat/disable-linter-rules-3333

Conversation

@giri256

@giri256 giri256 commented Jul 24, 2026

Copy link
Copy Markdown

Fixes #3333

Summary

  • Add --disable-linter-rules as a comma-separated string option for web-ext lint.
  • Support the corresponding lint.disableLinterRules config value.
  • Forward the value unchanged to addons-linter, which performs rule-name trimming and splitting internally.
  • Preserve current behavior when the option is omitted.

Validation

  • npx prettier --check src/program.js src/cmd/lint.js tests/unit/test.program.js tests/unit/test-cmd/test.lint.js
  • npx eslint src/program.js src/cmd/lint.js tests/unit/test.program.js tests/unit/test-cmd/test.lint.js
  • npx mocha tests/unit/test.program.js tests/unit/test-cmd/test.lint.js (69 passing)
  • npm run build
  • node bin/web-ext.js lint --source-dir tests/fixtures/minimal-web-ext --disable-linter-rules no-implied-eval --output json

@giri256

giri256 commented Jul 24, 2026

Copy link
Copy Markdown
Author

CI audit note: the only failing context is build-nodejs-current, at its final npm run audit-deps step. Prettier, unit/coverage tests, both functional-test modes, Node next/experimental, and Windows all pass.

The audit is reporting newly blocking advisories in existing dependencies (adm-zip, brace-expansion, fast-uri, and shell-quote); this PR does not modify dependency files. The same current-job failure pattern is also present on the repository's open Dependabot PRs #3780 and #3779, so this is not introduced by this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cannot make linter ignore specific rules

1 participant