Skip to content

📌 Pin scikit-build-core#384

Merged
burgholzer merged 1 commit into
mainfrom
pin-scikit-build-core
Jul 7, 2026
Merged

📌 Pin scikit-build-core#384
burgholzer merged 1 commit into
mainfrom
pin-scikit-build-core

Conversation

@denialhaag

Copy link
Copy Markdown
Member

Description

This PR pins scikit-build-core to ~=0.12 to prevent it from upgrading to version 1.0. The new version is incompatible with nanobind.stubgen. Once this issue is resolved, we can upgrade to 1.0 and benefit from the improved system for dynamic metadata. In particular, we should finally be able to drop our dependency on setuptools-scm.

Checklist

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

@denialhaag denialhaag requested a review from burgholzer July 6, 2026 23:20
@denialhaag denialhaag self-assigned this Jul 6, 2026
@denialhaag denialhaag added dependencies Pull requests that update a dependency file python Anything related to python code labels Jul 6, 2026
@burgholzer burgholzer merged commit 5f95a6b into main Jul 7, 2026
19 checks passed
@burgholzer burgholzer deleted the pin-scikit-build-core branch July 7, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python Anything related to python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants