Skip to content

Update link in DAO withdrawal process gotchas#454

Open
eval-exec wants to merge 1 commit into
nervosnetwork:masterfrom
eval-exec:patch-2
Open

Update link in DAO withdrawal process gotchas#454
eval-exec wants to merge 1 commit into
nervosnetwork:masterfrom
eval-exec:patch-2

Conversation

@eval-exec

@eval-exec eval-exec commented May 20, 2026

Copy link
Copy Markdown
Contributor

Add PR link for the "64 output cells limitation": nervosnetwork/ckb-system-scripts#93

@phroi @chenyukang @zhangsoledad @quake

@eval-exec eval-exec requested a review from doitian as a code owner May 20, 2026 08:54
Copilot AI review requested due to automatic review settings May 20, 2026 08:54
@eval-exec eval-exec requested a review from a team as a code owner May 20, 2026 08:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Nervos DAO deposit/withdraw RFC’s “Gotchas” section to include a direct reference to the upstream discussion about potentially relaxing the 64-output limit, giving readers a clearer path to follow future changes.

Changes:

  • Adds a link to nervosnetwork/ckb-system-scripts PR #93 from the “64 output cells” limitation note.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@phroi

phroi commented May 22, 2026

Copy link
Copy Markdown
Contributor

@eval-exec you see, that's the issue: most auditors still pick-up the design without the 64 bit limitation, which is not the one deployed on-chain.

Looking at the commit timestamps, the version actually committed on mainnet should be:

https://github.com/nervosnetwork/ckb-system-scripts/blob/f25c5ae8824c4907ad94326a0113a03defab9bfc/c/dao.c

The commit message reads "fix: NervosDAO review fixes" and it's dated 2019/11/02

The one instead I would like to propose as link in the DAO RFC is dated 2020/05/25, it has the same code except it greatly improve comments:

https://github.com/nervosnetwork/ckb-system-scripts/blob/814eb82c44f560dbdad2be97eb85464062920237/c/dao.c

Also it was the last commit on dao.c before my relatively recent PR.

Phroi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants