Update link in DAO withdrawal process gotchas#454
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Nervos DAO deposit/withdraw RFC’s “Gotchas” section to include a direct reference to the upstream discussion about potentially relaxing the 64-output limit, giving readers a clearer path to follow future changes.
Changes:
- Adds a link to
nervosnetwork/ckb-system-scriptsPR #93 from the “64 output cells” limitation note.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@eval-exec you see, that's the issue: most auditors still pick-up the design without the 64 bit limitation, which is not the one deployed on-chain. Looking at the commit timestamps, the version actually committed on mainnet should be: The commit message reads "fix: NervosDAO review fixes" and it's dated 2019/11/02 The one instead I would like to propose as link in the DAO RFC is dated 2020/05/25, it has the same code except it greatly improve comments: Also it was the last commit on dao.c before my relatively recent PR. Phroi |
Add PR link for the "64 output cells limitation": nervosnetwork/ckb-system-scripts#93
@phroi @chenyukang @zhangsoledad @quake