Fix chart popover dimension windowing#224
Merged
Merged
Conversation
ktsaou
marked this pull request as ready for review
July 16, 2026 14:21
novykh
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The previous end-window calculation could produce a negative start index. With 10 dimensions, a 10-row limit, and the highlighted dimension at sorted index 7, it calculated
from = -1;slice(-1, 10)then rendered only the final dimension even though the complete ordered list was unchanged.The duplicated bar implementation also rounded fractional boundaries outward for odd limits, which could render one row above the configured maximum.
Behavior after this change
Verification
yarn test --coverage --collectCoverageFrom=./src/**: 146 suites passed; 1,387 tests passed; 2 skippedapp.mem_page_faultsstacked chart: the same timestamp and 11-item ordering produced two correct 10-row windows, with exactly one item hidden above or belowScope
No payload, chart data, sorting, selection, or rendering-engine behavior changes.