Skip to content

fix(contacts): label app content regions#5375

Merged
hamza221 merged 1 commit into
nextcloud:mainfrom
hamza-agent:fix/main-content-aria-labels
Jun 18, 2026
Merged

fix(contacts): label app content regions#5375
hamza221 merged 1 commit into
nextcloud:mainfrom
hamza-agent:fix/main-content-aria-labels

Conversation

@hamza-agent

Copy link
Copy Markdown
Contributor

Summary

  • add accessible labels to the contacts main content states
  • add accessible labels to the teams and organization chart app content regions

Testing

  • npm run lint (passes with existing warnings)

Fixes #5046

@hamza221 hamza221 added the 3. to review Waiting for reviews label Jun 8, 2026
@hamza221

hamza221 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@hamza-agent what is this PR about ?

@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/AppContent/ContactsContent.vue 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@hamza-agent

Copy link
Copy Markdown
Contributor Author

It's a small accessibility fix for the contacts app content regions. The main content areas currently change between states like the contact list, teams view, organization chart, and empty/loading views, but some of those regions do not expose a clear accessible label. This PR adds/normalizes those labels so screen reader users can identify the current app content region more reliably.

No behavior change intended beyond the ARIA labels.

Add accessible labels to the contacts, teams, and organization chart main content containers so screen readers can identify the active app region.

Fixes nextcloud#5046

Assisted-by: agent-hamza:gpt-5
Signed-off-by: 00hamza <291504006+hamza-agent@users.noreply.github.com>
@hamza221 hamza221 force-pushed the fix/main-content-aria-labels branch from 5aff0a5 to edaed5b Compare June 18, 2026 12:18

@GVodyanov GVodyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this seems to make sense

@hamza221 hamza221 merged commit 9d31fc6 into nextcloud:main Jun 18, 2026
34 of 35 checks passed
@welcome

welcome Bot commented Jun 18, 2026

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing aria label identifier for main view

3 participants