Skip to content

Bugfix/noid/single app on linux using d bus#10088

Merged
mgallien merged 2 commits into
masterfrom
bugfix/noid/singleAppOnLinuxUsingDBus
Jun 12, 2026
Merged

Bugfix/noid/single app on linux using d bus#10088
mgallien merged 2 commits into
masterfrom
bugfix/noid/singleAppOnLinuxUsingDBus

Conversation

@mgallien

@mgallien mgallien commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Resolves

#

Summary

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Comment thread src/gui/application.cpp Outdated

@nilsding nilsding left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

@mgallien mgallien force-pushed the bugfix/noid/singleAppOnLinuxUsingDBus branch from ac77f8f to 79aa704 Compare June 10, 2026 14:44
@mgallien mgallien requested a review from nilsding June 10, 2026 14:46
@mgallien mgallien enabled auto-merge June 10, 2026 15:25
@mgallien mgallien force-pushed the bugfix/noid/singleAppOnLinuxUsingDBus branch from 79aa704 to 772db89 Compare June 12, 2026 08:29
@github-actions

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-10088.zip

Digest: sha256:a0f065c6a3d274034bce9cfe1456192822ef8d385a8311c5dc97a203ee924b77

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien disabled auto-merge June 12, 2026 09:21
mgallien added 2 commits June 12, 2026 11:21
should help to build end-to-end integration tests with desktop files
client and a Nextcloud server

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
to detect if the installed binary was changed while the client is
running, we used to synchronously try to run the binary to query its
version

this in addition with the need to prevent multiple running instances at
the same time is creating a deadlock on start

as an user, I do not expect my client to decide on its own to restart
after my distribution updated the native package

as a developer and administrator of a linux box, I expect the
distribution tools to take care of restarting what should be restarted
or at least notify about outdated running binaries

this should not have been in scope of the client

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/noid/singleAppOnLinuxUsingDBus branch from 772db89 to 29558c0 Compare June 12, 2026 09:21
@mgallien mgallien merged commit 7ffb382 into master Jun 12, 2026
15 of 17 checks passed
@mgallien mgallien deleted the bugfix/noid/singleAppOnLinuxUsingDBus branch June 12, 2026 09:22
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants