WIP: Python-based action#237
Draft
MillironX wants to merge 34 commits into
Draft
Conversation
GitHub Actions cannot access the `secrets` scope, they instead need to default to `github.token`.
In the case of a patch release that comes out after an edge release, we need to sort by release version, and not time. Leverage a single request to be able to get whichever version is actually the largest.
This was determined not to be the issue, and adds complexity This reverts commit 071009e.
This is in anticipation of adding more unit testing
As previous written, this action was not able to work on external pipelines. This is because the `github.action_path` scope is not available in a `uses:` block, but otherwise the consuming pipeline interprets `./` as relative to _its own_ working directory. This is another scuffed decision on GHA's part, but we have to live with it, and it actually explains some of the previous scoping issues and why we had a back-and-forth with requiring `actions/checkout` within this action. We fix that by moving everything into one YAML soup, and referencing each Python relative to `github.action_path`. There is also a change in scope of which directories are actually cached, as we need to ensure that secrets are not incorporated into the cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a work-in-progress to allow me to test some ideas in real, live CI before proposing sweeping changes. DO NOT review or merge until the Work-in-progress/draft flag has been removed. The tl;dr is that I think the JavaScript Action is too hard to maintain, but Philip Ewels' proposed Bash Action isn't quite powerful enough, so I am attempting a Python revision. Unfortunately, these kinds of changes really have to be tested in the CI system itself -
actis throwing a fit at the current revision.