tls: move _tls_* to end-of-life by bjohansebas · Pull Request #60658 · nodejs/node

bjohansebas · 2025-11-09T21:40:41Z

So that in Node.js 26 these modules are no longer there, and are now internal to Node.js only instead of public.

nodejs-github-bot · 2025-11-09T21:40:46Z

Review requested:

@nodejs/startup
@nodejs/userland-migrations

bjohansebas · 2025-11-09T21:45:21Z

cc: @nodejs/tsc since it’s an end-of-life deprecation

codecov · 2025-11-10T00:29:33Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.24%. Comparing base (b4c7be3) to head (7aa71f6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #60658   +/-   ##
=======================================
  Coverage   90.23%   90.24%           
=======================================
  Files         741      739    -2     
  Lines      241604   241581   -23     
  Branches    45520    45519    -1     
=======================================
- Hits       218010   218008    -2     
+ Misses      15120    15113    -7     
+ Partials     8474     8460   -14

Files with missing lines	Coverage Δ
lib/internal/main/mksnapshot.js	`95.71% <ø> (-0.05%)`	⬇️
src/node_builtins.cc	`76.32% <ø> (+0.18%)`	⬆️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bjohansebas · 2025-12-18T22:36:11Z

cc @nodejs/crypto @nodejs/net

nodejs-github-bot · 2025-12-19T17:10:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70530/

nodejs-github-bot · 2025-12-20T16:15:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70556/

bjohansebas · 2025-12-27T00:00:40Z

It looks flaky in GitHub Actions CI. Could someone rerun it, please?

bjohansebas · 2025-12-27T17:00:43Z

Should I do a rebase to see if it’s still failing?

aduh95 · 2025-12-27T17:04:48Z

Should I do a rebase to see if it’s still failing?

That wouldn't help (unless a fix for the flakiness had landed on main since last commit, but AFAIK that's not the case), and force us to re-review and re-run all CI jobs

nodejs-github-bot · 2026-01-20T21:10:34Z

Commit Queue failed

- Loading data for nodejs/node/pull/60658
✔  Done loading data for nodejs/node/pull/60658
----------------------------------- PR info ------------------------------------
Title      tls: move _tls_* to end-of-life (#60658)
Author     Sebastian Beltran <bjohansebas@gmail.com> (@bjohansebas)
Branch     bjohansebas:tls_eol -> nodejs:main
Labels     tls, c++, semver-major, author ready, deprecations, needs-ci, needs-citgm
Commits    1
 - tls: move _tls_* to end-of-life
Committers 1
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/60658
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/60658
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 09 Nov 2025 21:40:41 GMT
   ✔  Approvals: 2
   ✔  - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/60658#pullrequestreview-3597808519
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/60658#pullrequestreview-3613841924
   ✘  semver-major requires at least 2 TSC approvals
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-12-20T16:15:00Z: https://ci.nodejs.org/job/node-test-pull-request/70556/
- Querying data for job/node-test-pull-request/70556/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/21187285768

github-actions · 2026-07-11T21:34:42Z

Failed to start CI

- Validating Jenkins credentials
✔  Jenkins credentials valid
- Querying data for job/node-test-pull-request/71052/
[SyntaxError: Unexpected token '<', ..."    
  https://github.com/nodejs/node/actions/runs/29169017127

mcollina

lgtm

github-actions · 2026-07-11T23:13:39Z

Failed to start CI

- Validating Jenkins credentials
✔  Jenkins credentials valid
- Querying data for job/node-test-pull-request/71052/
[SyntaxError: Unexpected token '<', ..."    
  https://github.com/nodejs/node/actions/runs/29171769382

bjohansebas · 2026-07-12T00:10:50Z

Why is it failing?

nodejs-github-bot · 2026-07-12T01:39:20Z

Commit Queue failed

- Loading data for nodejs/node/pull/60658
✔  Done loading data for nodejs/node/pull/60658
----------------------------------- PR info ------------------------------------
Title      tls: move _tls_* to end-of-life (#60658)
Author     Sebastian Beltran <bjohansebas@gmail.com> (@bjohansebas)
Branch     bjohansebas:tls_eol -> nodejs:main
Labels     tls, c++, semver-major, notable-change, fast-track, author ready, deprecations, needs-ci, needs-citgm, request-ci-failed
Commits    1
 - tls: move _tls_* to end-of-life
Committers 1
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/60658
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/60658
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 09 Nov 2025 21:40:41 GMT
   ✔  Approvals: 4
   ✔  - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/60658#pullrequestreview-3597808519
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/60658#pullrequestreview-3708018086
   ✔  - Ethan Arrowood (@Ethan-Arrowood): https://github.com/nodejs/node/pull/60658#pullrequestreview-3693371964
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/60658#pullrequestreview-4678890733
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-01-26T21:14:49Z: https://ci.nodejs.org/job/node-test-pull-request/71052/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - tls: move _tls_* to end-of-life
- Querying data for job/node-test-pull-request/71052/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/29175511286

github-actions · 2026-07-12T02:42:32Z

Failed to start CI

- Validating Jenkins credentials
✔  Jenkins credentials valid
- Querying data for job/node-test-pull-request/71052/
[SyntaxError: Unexpected token '<', ..."    
  https://github.com/nodejs/node/actions/runs/29177144054

Renegade334 · 2026-07-12T05:16:25Z

Too old, needs rebasing.

bjohansebas · 2026-07-12T16:57:47Z

Too old, needs rebasing.

@Renegade334 done

Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>

nodejs-github-bot · 2026-07-12T20:42:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74767/

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. tls Issues and PRs related to the tls subsystem. labels Nov 9, 2025

bjohansebas force-pushed the tls_eol branch from 5eb6457 to 007a825 Compare November 9, 2025 21:43

bjohansebas added semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels Nov 9, 2025

AugustinMauroy approved these changes Nov 10, 2025

View reviewed changes

bjohansebas force-pushed the tls_eol branch from 007a825 to b913f6e Compare December 18, 2025 22:33

pimterry approved these changes Dec 19, 2025

View reviewed changes

pimterry added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2025

aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 19, 2025

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2025

RafaelGSS approved these changes Dec 26, 2025

View reviewed changes

aduh95 added the needs-citgm PRs that need a CITGM CI run. label Dec 30, 2025

bjohansebas added needs-citgm PRs that need a CITGM CI run. and removed needs-citgm PRs that need a CITGM CI run. labels Jan 14, 2026

mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 20, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 20, 2026

Ethan-Arrowood approved these changes Jan 22, 2026

View reviewed changes

mcollina approved these changes Jul 11, 2026

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 11, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 11, 2026

bjohansebas added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 12, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 12, 2026

github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jul 12, 2026

jasnell approved these changes Jul 12, 2026

View reviewed changes

bjohansebas force-pushed the tls_eol branch from acf2a11 to fc78623 Compare July 12, 2026 16:56

tls: move _tls_* to end-of-life

7aa71f6

Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>

bjohansebas force-pushed the tls_eol branch from fc78623 to 7aa71f6 Compare July 12, 2026 17:04

Renegade334 added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jul 12, 2026

Renegade334 approved these changes Jul 12, 2026

View reviewed changes

github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jul 12, 2026

This comment was marked as outdated.

Sign in to view

Renegade334 removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Jul 12, 2026

Uh oh!

Uh oh!

Conversation

bjohansebas commented Nov 9, 2025

Uh oh!

nodejs-github-bot commented Nov 9, 2025

Uh oh!

bjohansebas commented Nov 9, 2025

Uh oh!

codecov Bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bjohansebas commented Dec 18, 2025

Uh oh!

nodejs-github-bot commented Dec 19, 2025

Uh oh!

nodejs-github-bot commented Dec 20, 2025

Uh oh!

bjohansebas commented Dec 27, 2025

Uh oh!

bjohansebas commented Dec 27, 2025

Uh oh!

aduh95 commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 20, 2026

Uh oh!

github-actions Bot commented Jul 11, 2026

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 11, 2026

Uh oh!

bjohansebas commented Jul 12, 2026

Uh oh!

nodejs-github-bot commented Jul 12, 2026

Uh oh!

github-actions Bot commented Jul 12, 2026

Uh oh!

Renegade334 commented Jul 12, 2026

Uh oh!

bjohansebas commented Jul 12, 2026

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Jul 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

codecov Bot commented Nov 10, 2025 •

edited

Loading

aduh95 commented Dec 27, 2025 •

edited

Loading