doc: mention constructor check in deepStrictEqual#62010
Open
skdas20 wants to merge 2 commits into
Open
Conversation
nodejs-github-bot
added
assert
Renegade334
reviewed
Feb 27, 2026
| * [`[[Prototype]]`][prototype-spec] of objects are compared using | ||
| the [`===` operator][]. | ||
| * Only [enumerable "own" properties][] are considered. | ||
| * Object constructors are compared. |
Member
There was a problem hiding this comment.
Nit: Just for consistency with #60253, this should probably be
Suggested change
| * Object constructors are compared. | |
| * Object constructors are compared when available. |
BridgeAR
approved these changes
Apr 15, 2026
BridgeAR
left a comment
BridgeAR
left a comment
Member
There was a problem hiding this comment.
I guess this is a minimal improvement over the current state. I think including the recommendation by @Renegade334 would be good though
This was referenced May 20, 2026
Address review feedback from @Renegade334 for consistency with nodejs#60253.
Renegade334
approved these changes
Jul 25, 2026
Renegade334
added
author ready
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/62010 ✔ Done loading data for nodejs/node/pull/62010 ----------------------------------- PR info ------------------------------------ Title doc: mention constructor check in deepStrictEqual (#62010) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch skdas20:docs/assert-deepstrict-constructor-60239 -> nodejs:main Labels assert, doc, author ready, commit-queue-squash Commits 2 - doc: mention constructor check in deepStrictEqual - doc: clarify object constructors comparison is conditional Committers 2 - skdas20 <skdas5405@gmail.com> - Sumit Kumar Das <infinix26on@gmail.com> PR-URL: https://github.com/nodejs/node/pull/62010 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/62010 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 26 Feb 2026 18:28:01 GMT ✔ Approvals: 2 ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/62010#pullrequestreview-4115885758 ✔ - René (@Renegade334): https://github.com/nodejs/node/pull/62010#pullrequestreview-4780166416 ⚠ GitHub cannot link the author of 'doc: clarify object constructors comparison is conditional' to their GitHub account. ⚠ Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork ✘ 1 GitHub CI job(s) failed: ✘ - lint-commit-message: FAILURE (https://github.com/nodejs/node/actions/runs/30171196870/job/89721068285) ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/30176654826 |
trivikr
removed
commit-queue-failed
Member
|
@skdas20 Can you please sign the first commit and force push? It's needed as per instructions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60239
Summary
Adds missing comparison detail to
assert.deepStrictEqual()docs:This aligns the
assertdocs with current behavior and existingutil.isDeepStrictEqual()documentation.Validation
Ran markdown lint on the changed file:
Result: exit code
0.