lib: insert argv[0] at argv[1] in setDeserializeMainFunction by watilde · Pull Request #62928 · nodejs/node

watilde · 2026-04-24T14:47:40Z

No description provided.

nodejs-github-bot · 2026-04-24T14:47:45Z

Review requested:

@nodejs/startup

codecov · 2026-04-24T16:46:26Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.62%. Comparing base (2428030) to head (3f12b2c).
⚠️ Report is 499 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62928      +/-   ##
==========================================
- Coverage   89.63%   89.62%   -0.01%     
==========================================
  Files         706      706              
  Lines      219219   219219              
  Branches    42004    42002       -2     
==========================================
- Hits       196499   196483      -16     
- Misses      14622    14636      +14     
- Partials     8098     8100       +2

Files with missing lines	Coverage Δ
lib/internal/v8/startup_snapshot.js	`95.38% <100.00%> (ø)`

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2026-04-25T02:38:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72916/

watilde · 2026-05-20T23:26:58Z

This needs another @nodejs/tsc review, thanks!

nodejs-github-bot · 2026-06-08T13:11:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/73975/

nodejs-github-bot · 2026-06-08T16:09:32Z

Commit Queue failed

- Loading data for nodejs/node/pull/62928
✔  Done loading data for nodejs/node/pull/62928
----------------------------------- PR info ------------------------------------
Title      lib: insert argv[0] at argv[1] in setDeserializeMainFunction (#62928)
Author     Daijiro Wachi <daijiro.wachi@gmail.com> (@watilde)
Branch     watilde:snapshot-des -> nodejs:main
Labels     semver-major, author ready, needs-ci, v8 module
Commits    1
 - lib: insert argv[0] at argv[1] in setDeserializeMainFunction
Committers 1
 - Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/62928
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62928
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 24 Apr 2026 14:47:40 GMT
   ✔  Approvals: 2
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/62928#pullrequestreview-4173653011
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/62928#pullrequestreview-4449750587
   ✘  GitHub CI failed with status: FAILURE
   ℹ  Last Full PR CI on 2026-06-08T13:11:50Z: https://ci.nodejs.org/job/node-test-pull-request/73975/
- Querying data for job/node-test-pull-request/73975/
✔  Build data downloaded
- Querying failures of job/node-test-commit/88517/
✔  Data downloaded
   ✘  1 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/27150717876

nodejs-github-bot · 2026-06-09T03:49:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/73985/

nodejs-github-bot · 2026-06-09T14:20:51Z

Commit Queue failed

- Loading data for nodejs/node/pull/62928 ✔ Done loading data for nodejs/node/pull/62928 ----------------------------------- PR info ------------------------------------ Title lib: insert argv[0] at argv[1] in setDeserializeMainFunction (#62928) Author Daijiro Wachi <daijiro.wachi@gmail.com> (@watilde) Branch watilde:snapshot-des -> nodejs:main Labels semver-major, author ready, needs-ci, v8 module Commits 1 - lib: insert argv[0] at argv[1] in setDeserializeMainFunction Committers 1 - Daijiro Wachi <daijiro.wachi@gmail.com> PR-URL: https://github.com/nodejs/node/pull/62928 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/62928 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 24 Apr 2026 14:47:40 GMT ✔ Approvals: 2 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/62928#pullrequestreview-4173653011 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/62928#pullrequestreview-4449750587 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-06-09T03:49:21Z: https://ci.nodejs.org/job/node-test-pull-request/73985/ - Querying data for job/node-test-pull-request/73985/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 62928 From https://github.com/nodejs/node * branch refs/pull/62928/merge -> FETCH_HEAD ✔ Fetched commits as 5e645ccf5538..3f12b2cef97b -------------------------------------------------------------------------------- Auto-merging doc/api/v8.md Auto-merging lib/internal/v8/startup_snapshot.js [main b6f94eafb4] lib: insert argv[0] at argv[1] in setDeserializeMainFunction Author: Daijiro Wachi <daijiro.wachi@gmail.com> Date: Fri Apr 24 23:56:49 2026 +0900 8 files changed, 11 insertions(+), 10 deletions(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- lib: insert argv[0] at argv[1] in setDeserializeMainFunction

PR-URL: #62928
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

[main e1cce1fc4d] lib: insert argv[0] at argv[1] in setDeserializeMainFunction
Author: Daijiro Wachi <daijiro.wachi@gmail.com>
Date: Fri Apr 24 23:56:49 2026 +0900
8 files changed, 11 insertions(+), 10 deletions(-)
✖ e1cce1fc4dd30ebe6956a3cb29286118e52f6609
✔ 0:0 no Assisted-by metadata assisted-by-is-trailer
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✖ 0:0 Commit must have a "Signed-off-by" trailer signed-off-by
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
⚠ 0:50 Title should be <= 50 columns. title-length

ℹ Please fix the commit message and try again.
Please manually ammend the commit message, by running
git commit --amend
Once commit message is fixed, finish the landing command running
git node land --continue

https://github.com/nodejs/node/actions/runs/27212419294

Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>

nodejs-github-bot · 2026-06-10T01:25:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74009/

Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com> PR-URL: #62928 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

watilde · 2026-06-10T02:36:30Z

Landed in 19c46ab

nodejs-github-bot added needs-ci PRs that need a full CI run. v8 module Issues and PRs related to the "v8" subsystem. labels Apr 24, 2026

watilde force-pushed the snapshot-des branch from 56e0299 to 3f12b2c Compare April 24, 2026 14:56

watilde requested a review from joyeecheung April 24, 2026 14:57

watilde changed the title ~~snapshot: insert argv[0] at argv[1] in setDeserializeMainFunction~~ lib: insert argv[0] at argv[1] in setDeserializeMainFunction Apr 24, 2026

joyeecheung approved these changes Apr 24, 2026

View reviewed changes

joyeecheung added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 24, 2026

watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2026

watilde added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 30, 2026

legendecas approved these changes Jun 8, 2026

View reviewed changes

watilde added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 8, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 8, 2026

This comment was marked as outdated.

Sign in to view

watilde added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 9, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 9, 2026

lib: insert argv[0] at argv[1] in setDeserializeMainFunction

f8ee166

Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>

watilde force-pushed the snapshot-des branch from 3f12b2c to f8ee166 Compare June 10, 2026 00:41

watilde removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jun 10, 2026

watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2026

watilde closed this Jun 10, 2026

watilde deleted the snapshot-des branch June 10, 2026 02:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

lib: insert argv[0] at argv[1] in setDeserializeMainFunction#62928

lib: insert argv[0] at argv[1] in setDeserializeMainFunction#62928
watilde wants to merge 1 commit into
nodejs:mainfrom
watilde:snapshot-des

watilde commented Apr 24, 2026

Uh oh!

nodejs-github-bot commented Apr 24, 2026

Uh oh!

codecov Bot commented Apr 24, 2026 •

edited

Loading

Uh oh!

nodejs-github-bot commented Apr 25, 2026

Uh oh!

watilde commented May 20, 2026

Uh oh!

nodejs-github-bot commented Jun 8, 2026

Uh oh!

nodejs-github-bot commented Jun 8, 2026

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Jun 9, 2026

Uh oh!

nodejs-github-bot commented Jun 9, 2026

PR-URL: #62928
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Uh oh!

nodejs-github-bot commented Jun 10, 2026

Uh oh!

watilde commented Jun 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

watilde commented Apr 24, 2026

Uh oh!

nodejs-github-bot commented Apr 24, 2026

Uh oh!

codecov Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Apr 25, 2026

Uh oh!

watilde commented May 20, 2026

Uh oh!

nodejs-github-bot commented Jun 8, 2026

Uh oh!

nodejs-github-bot commented Jun 8, 2026

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Jun 9, 2026

Uh oh!

nodejs-github-bot commented Jun 9, 2026

PR-URL: #62928 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Uh oh!

nodejs-github-bot commented Jun 10, 2026

Uh oh!

watilde commented Jun 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Apr 24, 2026 •

edited

Loading

PR-URL: #62928
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>