test: copyedit test-tls-psk-alpn-callback-exception-handling

[aduh95]

Make the assertions more intention revealing

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.22%. Comparing base (e7864e6) to head (8a1f4ec).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #63485      +/-   ##
==========================================
- Coverage   90.24%   90.22%   -0.03%     
==========================================
  Files         741      741              
  Lines      241665   241665              
  Branches    45543    45538       -5     
==========================================
- Hits       218092   218043      -49     
- Misses      15105    15158      +53     
+ Partials     8468     8464       -4     

see 31 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Renegade334]

What happens if this fires while promise is being awaited at the end of the test function, and tlsClientError doesn't fire? Seems like the event will be handled outside of the test's promise task, promise won't be resolved or rejected, and the test will hang until timeout?

[aduh95]

node/test/common/index.js

Lines 563 to 572 in 5922197

	function mustNotCall(msg) {
	const callSite = getCallSites()[1];
	return function mustNotCall(...args) {
	const argsInfo = args.length > 0 ?
	`\ncalled with arguments: ${args.map((arg) => inspect(arg)).join(', ')}` : '';
	assert.fail(
	`${msg || 'function should not have been called'} at ${callSite.scriptName}:${callSite.lineNumber}` +
	argsInfo);
	};
	}

It would throw an unhandled rejection which would terminate the process immediately
In any case, a pending promise is not enough to keep the process alive, so no the test won't hang

[mcollina]

lgtm

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/74781/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/74795/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/74805/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/74810/

[nodejs-github-bot]

Landed in 824bc66