net: support TCP_KEEPINTVL and TCP_KEEPCNT in setKeepAlive#63825
Open
guybedford wants to merge 1 commit into
Open
net: support TCP_KEEPINTVL and TCP_KEEPCNT in setKeepAlive#63825guybedford wants to merge 1 commit into
guybedford wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
88d729f to
da04b2d
Compare
Signed-off-by: Guy Bedford <guybedford@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends
setKeepAlive()fornet.Socketbased on the newer UVuv_tcp_keepalive_exextension with allows setting these optional arguments for the probe interval and probe count, effectively closing the gap onsetsockopt(2)compatibility.This does not extend this option to other constructors accepting keepalive options currently although that could also be added as well.
Both new values default to the previous libuv behaviour (1000 ms interval, 10 probes), so existing calls are unaffected.