Skip to content

tools: pin to nixpkgs-26.05-darwin on Intel Macs#64210

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:x64-darwin-extended-support
Jul 12, 2026
Merged

tools: pin to nixpkgs-26.05-darwin on Intel Macs#64210
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:x64-darwin-extended-support

Conversation

@aduh95

@aduh95 aduh95 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Unstable channel no longer supports Intel architecture for macOS. We can use the 26.05 channel to keep testing on that platform for a little longer. Hopefully we won't see (m)any 26.05 problems.

Alternatives would be:

  • pin to 26.05 on all platforms (not sure this is worth it)
  • drop GHA support for Intel Macs (feels early, and would mean that e.g. we can longer benchmark on that platform)

@aduh95
tools: pin to nixpkgs-26.05-darwin on Intel Macs
353b51e 
Unstable channel no longer supports Intel architecture for macOS. We can
use the 26.05 channel to keep testing on that platform for a little
longer.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

nodejs-github-bot commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 30, 2026
@Renegade334 Renegade334 mentioned this pull request Jul 12, 2026
Closed
@aduh95
aduh95 requested a review from panva July 12, 2026 09:01
panva
panva approved these changes Jul 12, 2026
View reviewed changes

@panva panva left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 12, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 12, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 71812d1 into nodejs:main Jul 12, 2026
57 of 59 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Landed in 71812d1

@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels Jul 12, 2026
@aduh95
aduh95 deleted the x64-darwin-extended-support branch July 13, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aduh95 @nodejs-github-bot @panva