stream: avoid draining merged iter sources#64293
Merged
nodejs-github-bot merged 1 commit intoJul 8, 2026
Merged
Conversation
Collaborator
|
Review requested:
|
Defer reading the next value from each source in merge() until the merged consumer resumes after receiving the previous value. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
61b6bd2 to
0b25aaa
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64293 +/- ##
=======================================
Coverage 90.25% 90.25%
=======================================
Files 741 741
Lines 241165 241167 +2
Branches 45428 45419 -9
=======================================
+ Hits 217667 217669 +2
Misses 15069 15069
Partials 8429 8429
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Jul 8, 2026
Collaborator
gurgunday
approved these changes
Jul 8, 2026
efekrskl
approved these changes
Jul 8, 2026
Collaborator
|
Landed in 0032189 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #63566
stream/itermerge()was scheduling the next read from a source as soon asthat source produced a value. For fast sources, this could drain all inputs even
while the merged consumer was idle after a single
next().This defers each source's next read until the merged iterator resumes after
yielding the previous value.
Assisted-by: openai:gpt-5.5