test_runner: add context.log() and test:log event#64389
Open
MoLow wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
Add a log(message[, data]) method to TestContext and SuiteContext that emits a new test:log event. Unlike test:diagnostic, which is buffered so it is emitted in the order tests are defined, test:log is emitted immediately, in the order tests execute, including under process isolation where it bypasses the per-file declaration order buffer. This gives reporters that render the test tree unbuffered a live, attributed logging channel that captured stdout cannot provide under concurrency. The event carries the message, an optional opaque structured payload that the runner passes through untouched, and the emitting test's name, testId, parentId, nesting, and location. Built-in reporters render it the same way they render test:diagnostic. Signed-off-by: Moses Atlow <moshe@atlow.co.il>
Codecov Reportβ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64389 +/- ##
=======================================
Coverage 90.25% 90.25%
=======================================
Files 741 741
Lines 241207 241242 +35
Branches 45424 45436 +12
=======================================
+ Hits 217696 217733 +37
+ Misses 15087 15079 -8
- Partials 8424 8430 +6
π New features to boost your workflow:
|
benjamingr
approved these changes
Jul 9, 2026
MoLow
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
atlowChemi
approved these changes
Jul 9, 2026
MoLow
added
the
commit-queue
Renegade334
added
semver-minor
Contributor
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/64389 β Done loading data for nodejs/node/pull/64389 ----------------------------------- PR info ------------------------------------ Title test_runner: add `context.log()` and `test:log` event (#64389) Author Moshe Atlow <moshe@atlow.co.il> (@MoLow) Branch MoLow:test-runner-log -> nodejs:main Labels semver-minor, lib / src, notable-change, author ready, needs-ci Commits 1 - test_runner: add context.log() and test:log event Committers 1 - Moshe Atlow <moshe@atlow.co.il> PR-URL: https://github.com/nodejs/node/pull/64389 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64389 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> -------------------------------------------------------------------------------- βΉ This PR was created on Thu, 09 Jul 2026 09:58:25 GMT β Approvals: 2 β - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/64389#pullrequestreview-4662895197 β - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/64389#pullrequestreview-4664897612 β Last GitHub CI successful βΉ Last Full PR CI on 2026-07-09T13:47:17Z: https://ci.nodejs.org/job/node-test-pull-request/74690/ - Querying data for job/node-test-pull-request/74690/ β Build data downloaded β Last Jenkins CI successful -------------------------------------------------------------------------------- β No git cherry-pick in progress β No git am in progress β No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD β origin/main is now up-to-date - Downloading patch for 64389 From https://github.com/nodejs/node * branch refs/pull/64389/merge -> FETCH_HEAD β Fetched commits as 26079c0cfa62..645ad450751b -------------------------------------------------------------------------------- Auto-merging doc/api/test.md CONFLICT (content): Merge conflict in doc/api/test.md error: could not apply 645ad45075... test_runner: add context.log() and test:log event hint: After resolving the conflicts, mark them with hint: "git add/rm <pathspec>", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort". hint: Disable this message with "git config set advice.mergeConflict false" β Failed to apply patcheshttps://github.com/nodejs/node/actions/runs/29148679566 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a log(message[, data]) method to
TestContextandSuiteContextthat emits a newtest:logevent.Unlike
test:diagnostic, which is buffered so it is emitted in the order tests are defined,test:logis emitted immediately, in the order tests execute, including under process isolation where it bypasses the per-file declaration order buffer.Motivation for adding this
This gives reporters that render the test tree unbuffered a live, attributed logging channel that captured stdout cannot provide under concurrency (see for example https://www.npmjs.com/package/@reporters/live and https://www.npmjs.com/package/@reporters/web).
The event carries the message, an optional opaque structured payload that the runner passes through untouched, and the emitting test's name, testId, parentId, nesting, and location.
Built-in reporters render it the same way they render
test:diagnostic.