Skip to content

[IMP] MRP: Subcontractor Stock on BOM Overview#19079

Open
stepperpig wants to merge 1 commit into
saas-19.4from
saas-19.4-mrp-subcontracting-stock-kaili
Open

[IMP] MRP: Subcontractor Stock on BOM Overview#19079
stepperpig wants to merge 1 commit into
saas-19.4from
saas-19.4-mrp-subcontracting-stock-kaili

Conversation

@stepperpig

Copy link
Copy Markdown
Contributor

Description

This PR updates the 'BOM Overview' section of the 'Bill of Materials' page to reflect the addition of the 'Subcontractor Stock' column for subcontracted products when the Forecast mode is enabled in BOM Overview in 19.4. Previously, this column did not exist and the overview tracked only the available stock at the subcontractor-level. This feature adds a separate subcontractor-specific column to separate stock information between the company- and subcontractor-levels, keeping track of each individually for clarity.

Task card

Changelog

  • Clarification added to 'BoM Overview' section of 'Bill of materials' page
  • Unrelated spacing issues fixed

Version Scope

This PR can be FWP up to master.
Additional PRs may be opened to address missing BOM overview document pre-19.3.

@stepperpig stepperpig self-assigned this Jul 23, 2026
@stepperpig stepperpig added the 2 label Jul 23, 2026
@robodoo

robodoo commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Pull request status dashboard

@C3POdoo
C3POdoo requested a review from a team July 23, 2026 17:37
@stepperpig

Copy link
Copy Markdown
Contributor Author

Hi @theRealThagomizer got a PR ready for your review when you get a chance - thank you

@stepperpig
stepperpig removed the request for review from a team July 23, 2026 17:38

@theRealThagomizer theRealThagomizer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya, @stepperpig! Looks like this doc has had some of the same issues I've run into with other 19.4 updates -- it looks like there's been a bunch of knock-on effects caused by the changes that the devs made. I'm marking this as "Request changes" because the workflows this doc captures appear to have changed substantially enough in places that they can't be followed as outlined. I also cleaned up a few style convention things. Sorry to turn this into more work for you, but at least it ought to be worth more points now!


Use the *Worksheet* tab to upload a supplementary PDF that will display when the operator
completes that step.
Use the *Worksheet* tab to upload a supplementary PDF that will display when the operator completes

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Use the *Worksheet* tab to upload a supplementary PDF that will display when the operator completes
Use the *Worksheet* tab to upload a supplementary PDF that displays when the operator completes

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where should this appear? If we're still in the Create Quality Point pop-up, I'm only seeing Instructions, Message If Failure, and Notes as tabs.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the previous reply about saving the operation form first before creating a QC point. After doing so there should be an additional tab, which is functionally the same but named differently, called "Attachment", not "Worksheet"... so good catch nonetheless.

Comment on lines 271 to 272

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Experience has changed? Selecting a BOM and clicking the Action button doesn't bring up "Show BoM Lines". Might be "Compare BoMs" now?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah you're right. It should be "compare BoMs" now, which by default opens in the pivot view. Opening the list view should open the lines as described here.

Comment on lines 318 to 320
Optionally, the :guilabel:`Cost Share` percentage of a by-product can also be specified at this
stage. The cost share is the percentage of the final production cost for the by-product, divided by
the quantity produced. The total of all by-products' cost share must be less than or equal to `100`.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't jump out as being part of the flow at this point.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be worth finding a better place in a future PR... think it might be worth just keeping all the functional specifics up-to-date in this PR.

Comment on lines 406 to 407

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not seeing this by default.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch... might be worth clarifying that this works for multi-level BoMs where components have BoMs and can be folded for visual ease.

Co-authored-by: theRealThagomizer <96515928+theRealThagomizer@users.noreply.github.com>
@stepperpig
stepperpig force-pushed the saas-19.4-mrp-subcontracting-stock-kaili branch from f2f6092 to 01118ad Compare July 23, 2026 23:43
@stepperpig

Copy link
Copy Markdown
Contributor Author

@theRealThagomizer just went and fixed a few things. this doc might need some further work in the future (e.g., separating it out into separate docs), but for now i'll restrict any changes to just making sure it appears and functions correctly for 19.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants