[IMP] MRP: Subcontractor Stock on BOM Overview#19079
Conversation
|
Hi @theRealThagomizer got a PR ready for your review when you get a chance - thank you |
theRealThagomizer
left a comment
There was a problem hiding this comment.
Hiya, @stepperpig! Looks like this doc has had some of the same issues I've run into with other 19.4 updates -- it looks like there's been a bunch of knock-on effects caused by the changes that the devs made. I'm marking this as "Request changes" because the workflows this doc captures appear to have changed substantially enough in places that they can't be followed as outlined. I also cleaned up a few style convention things. Sorry to turn this into more work for you, but at least it ought to be worth more points now!
|
|
||
| Use the *Worksheet* tab to upload a supplementary PDF that will display when the operator | ||
| completes that step. | ||
| Use the *Worksheet* tab to upload a supplementary PDF that will display when the operator completes |
There was a problem hiding this comment.
| Use the *Worksheet* tab to upload a supplementary PDF that will display when the operator completes | |
| Use the *Worksheet* tab to upload a supplementary PDF that displays when the operator completes |
There was a problem hiding this comment.
Where should this appear? If we're still in the Create Quality Point pop-up, I'm only seeing Instructions, Message If Failure, and Notes as tabs.
There was a problem hiding this comment.
See the previous reply about saving the operation form first before creating a QC point. After doing so there should be an additional tab, which is functionally the same but named differently, called "Attachment", not "Worksheet"... so good catch nonetheless.
There was a problem hiding this comment.
Experience has changed? Selecting a BOM and clicking the Action button doesn't bring up "Show BoM Lines". Might be "Compare BoMs" now?
There was a problem hiding this comment.
yeah you're right. It should be "compare BoMs" now, which by default opens in the pivot view. Opening the list view should open the lines as described here.
| Optionally, the :guilabel:`Cost Share` percentage of a by-product can also be specified at this | ||
| stage. The cost share is the percentage of the final production cost for the by-product, divided by | ||
| the quantity produced. The total of all by-products' cost share must be less than or equal to `100`. |
There was a problem hiding this comment.
This doesn't jump out as being part of the flow at this point.
There was a problem hiding this comment.
may be worth finding a better place in a future PR... think it might be worth just keeping all the functional specifics up-to-date in this PR.
There was a problem hiding this comment.
Not seeing this by default.
There was a problem hiding this comment.
good catch... might be worth clarifying that this works for multi-level BoMs where components have BoMs and can be folded for visual ease.
Co-authored-by: theRealThagomizer <96515928+theRealThagomizer@users.noreply.github.com>
f2f6092 to
01118ad
Compare
|
@theRealThagomizer just went and fixed a few things. this doc might need some further work in the future (e.g., separating it out into separate docs), but for now i'll restrict any changes to just making sure it appears and functions correctly for 19.4. |

Description
This PR updates the 'BOM Overview' section of the 'Bill of Materials' page to reflect the addition of the 'Subcontractor Stock' column for subcontracted products when the Forecast mode is enabled in BOM Overview in 19.4. Previously, this column did not exist and the overview tracked only the available stock at the subcontractor-level. This feature adds a separate subcontractor-specific column to separate stock information between the company- and subcontractor-levels, keeping track of each individually for clarity.
Task card
Changelog
Version Scope
This PR can be FWP up to master.
Additional PRs may be opened to address missing BOM overview document pre-19.3.