perf: cache clientMetadata lambda to avoid per-call allocation

[tobias-ibounig-dt]

This PR

• Caches the ClientMetadata lambda in a final field to avoid re-allocating it on every getMetadata() call

Related Issues

None

Notes

getMetadata() is called once per flag evaluation to build the SharedHookContext. Previously it returned this::getDomain — a new lambda instance each time. The field is initialized once in the constructor.

Allocation impact is negligible, but reduces on totalAllocatedInstances can be seen.

Metric	main (baseline)	This PR	Delta
run:+totalAllocatedBytes	124,265,984	124,265,984	0
run:+totalAllocatedInstances	2,723,316	2,674,636	−48,680 (−1.8%)

Follow-up Tasks

• More PRs with memory improvements
• Update benchmark.txt after all are applied

[gemini-code-assist]

Code Review

This pull request refactors OpenFeatureClient to store a clientMetadata field initialized with a lambda reference in the constructor, returning it in getMetadata(). The reviewer suggests optimizing this further by having OpenFeatureClient directly implement the ClientMetadata interface, which would allow getMetadata() to return this and completely eliminate the extra field and lambda allocation.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[toddbaert]

Same codecov-action issue as #1955 (comment) - rebasing this PR onto main should fix it. cc @chrfwow

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.27%. Comparing base (b611d55) to head (12c0939).

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1952      +/-   ##
============================================
+ Coverage     92.25%   93.27%   +1.01%     
- Complexity      654      657       +3     
============================================
  Files            59       59              
  Lines          1589     1590       +1     
  Branches        179      179              
============================================
+ Hits           1466     1483      +17     
+ Misses           76       62      -14     
+ Partials         47       45       -2     

Flag	Coverage Δ
unittests	93.27% <100.00%> (+1.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.