ompi nightly tarball builder - use python venv#97
Open
hppritcha wants to merge 1 commit into
Open
Conversation
since we now rely on sphinx python modules that are not available via linux package managers. This patch reenables nightly tarball builds which had not been happening since mid January 2026. Signed-off-by: Howard Pritchard <howardp@lanl.gov>
jsquyres
reviewed
Jun 21, 2026
jsquyres
left a comment
jsquyres
left a comment
Member
There was a problem hiding this comment.
@hppritcha Is this fixing a problem? I thought that @bwbarrett made the AWS images such that the sphinx modules were globally installed somewhere (but I could be wrong).
Member
Author
|
nope they are not. the sphinxobj thingy isn't part of a distro and @bwbarrett suggested the venv approach. |
jsquyres
reviewed
Jun 22, 2026
| # not all of which are available via linux distros, | ||
| # so set up a virtual env to run the command in | ||
| # | ||
| REQ_FILE="${PWD}/docs/requirements.txt" |
Member
There was a problem hiding this comment.
Can you make this check 2 things:
- If
${PWD}/requirements.txtexists, use that. - Otherwise, if
${PWD}/requirements.txtexists, use that.
With the llms.txt stuff that went in, we now have a top-level requirements.txt that contains the union of all the pip's we need across the OMPI source tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since we now rely on sphinx python modules that are not available via linux package managers.
This patch reenables nightly tarball builds which had not been happening since mid January 2026.