feat(migrate): support return statements in IfElseIfConstructToSwitch recipe#1162
Open
arnabnandy7 wants to merge 1 commit into
Open
feat(migrate): support return statements in IfElseIfConstructToSwitch recipe#1162arnabnandy7 wants to merge 1 commit into
arnabnandy7 wants to merge 1 commit into
Conversation
… recipe Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Allows converting if-else-if chains containing return statements to switch statements.
returns(...)guard invalidatePotentialCandidate()withinIfElseIfConstructToSwitch.java.buildSwitchTemplate()to check if the branch statement is a bareJ.Return. If so, it wraps it in block braces at the template-compilation level (case X -> {#{any()};}).IfElseIfConstructToSwitchTest.javato expect successful switch conversions, and added new tests to cover mixed branches, braceless return chains, and nested returns.What's your motivation?
Anything in particular you'd like reviewers to focus on?
{#{any()};}to ensure the mock code parsed inJavaTemplateis valid while avoiding double semicolons during replacement.Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
An alternative would have been to manually synthesize
J.BlockAST nodes in the visitor before applyingJavaTemplate. However, wrapping the raw return in explicit braces at the template-string level is much cleaner and less error-prone.Any additional context
Checklist