OCPBUGS-65469: Add debug-useful ClusterOperator relatedObjects

[RadekManak]

Expand cloud-controller-manager ClusterOperator relatedObjects so must-gather / oc adm inspect pick up RBAC that namespace inspect does not collect.

Keeps the existing ClusterOperator + namespace entries and adds debug-useful cluster-scoped / foreign-namespace RBAC (not a full inventory of every managed object).

Added relatedObjects

• ClusterRoles: system:openshift:operator:cloud-controller-manager, cloud-controller-manager, cloud-node-manager
• ClusterRoleBindings: matching bindings above, plus SCC hostaccess for the operator
• Roles / RoleBindings in openshift-config, openshift-config-managed, and kube-system

Runtime

Platform-specific relatedObjects (provider ClusterRoles/CRBs, admission policies, etc.) are appended from Infrastructure at reconcile time.

Tests

Parity test keeping the static Go list in sync with the ClusterOperator manifest.

[openshift-ci-robot]

@RadekManak: This pull request references Jira Issue OCPBUGS-65469, which is invalid:

• expected the bug to target either version "5.0." or "openshift-5.0.", but it targets "4.21.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Adds all resources managed by the cloud-controller-manager operator to the ClusterOperator's relatedObjects list, ensuring oc adm inspect and must-gather collect the complete set of resources needed for debugging.

Resources added

• ConfigMaps (cloud-controller-manager-images, kube-rbac-proxy)
• Services, Deployments
• NetworkPolicies
• ServiceAccounts
• Roles and RoleBindings (operator, openshift-config, openshift-config-managed, kube-system namespaces)
• ClusterRoles and ClusterRoleBindings (operator, cloud-node-manager, openstack-cloud-controller-manager)
• CredentialsRequests (Azure, GCP, IBM, Nutanix, OpenStack, PowerVS, vSphere)

Also fixes the namespace ordering to list the operator namespace (openshift-cloud-controller-manager-operator) before the managed namespace (openshift-cloud-controller-manager).

Both the static manifest YAML and the Go source are kept in sync.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

The change expands status.relatedObjects in the controller and corresponding ClusterOperator manifest to include broader cluster-scoped and namespace-scoped resources, especially RBAC objects across several namespaces.

Changes

Related object reporting

Layer / File(s)	Summary
Expanded related object inventory pkg/controllers/status.go, manifests/..._60_clusteroperator.yaml	The controller returns a larger set of ObjectReference entries, while the manifest adds cluster roles, bindings, roles, and rolebindings across the operator, configuration, and system namespaces.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: nrb, racheljpg

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Added Ginkgo title is static and descriptive; no dynamic values, timestamps, or generated identifiers appear in touched tests.
Test Structure And Quality	✅ Passed	No Ginkgo test code was modified; the PR only touches controller status logic and a manifest, so the test-structure check is not applicable.
Microshift Test Compatibility	✅ Passed	No e2e tests were added; the new Ginkgo tests are unit tests under pkg/controllers, so this MicroShift check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	New Ginkgo tests are unit/manifest-sync checks; they don’t assume multiple nodes or HA, so no SNO-specific guard is needed.
Topology-Aware Scheduling Compatibility	✅ Passed	Changed files only expand ClusterOperator relatedObjects and sync the manifest; no node selectors, affinity, spread, replicas, or topology assumptions were added.
Ote Binary Stdout Contract	✅ Passed	PASS: Diff only expands relatedObjects helpers and Ginkgo It tests; no main/init/TestMain/BeforeSuite code or stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new e2e/network-sensitive tests were added; the new Ginkgo test only reads a local manifest and compares relatedObjects, with no IPv4 or external connectivity assumptions.
No-Weak-Crypto	✅ Passed	No weak crypto primitives, custom crypto, or secret comparisons were added in the changed Go or manifest files.
Container-Privileges	✅ Passed	No privileged/hostPID/hostNetwork/hostIPC/allowPrivilegeEscalation/SYS_ADMIN fields were added; the PR only expands relatedObjects and sync tests.
No-Sensitive-Data-In-Logs	✅ Passed	Changed code only expands relatedObjects; existing klog messages are generic and do not log secrets, PII, or hostnames.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the main change: expanding ClusterOperator relatedObjects for debugging.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign racheljpg for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[RadekManak]

/retest

[RadekManak]

/jira refresh

[openshift-ci-robot]

@RadekManak: This pull request references Jira Issue OCPBUGS-65469, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: sunzhaohua2.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@RadekManak: This pull request references Jira Issue OCPBUGS-65469, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[RadekManak]

/retest-required

[openshift-ci]

@RadekManak: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.